Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upstream methods to indicate they are now decommissioned. #6508

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Update upstream methods to indicate they are now decommissioned. #6508

merged 2 commits into from
Nov 13, 2024

Conversation

gsakakihara
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Javadoc Changes: 
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/messaging/FirebaseMessaging.html	2024-11-13 17:59:02.985298936 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/messaging/FirebaseMessaging.html	2024-11-13 17:56:59.392009536 +0000
@@ -96,7 +96,7 @@
             <td>
               <div><code><span><del><a href="/docs/reference/android/com/google/firebase/messaging/FirebaseMessaging.html#send(com.google.firebase.messaging.RemoteMessage)">send</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/messaging/RemoteMessage.html">RemoteMessage</a>&nbsp;message)</code></div>
               <p><strong>This method is deprecated.</strong>
-                <p>FCM upstream messaging is decommissioned.</p>
+                <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging.</p>
               </p>
             </td>
           </tr>
@@ -272,7 +272,7 @@
         <h3 class="api-name" id="send(com.google.firebase.messaging.RemoteMessage)">send</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;void&nbsp;<span><del><a href="/docs/reference/android/com/google/firebase/messaging/FirebaseMessaging.html#send(com.google.firebase.messaging.RemoteMessage)">send</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/messaging/RemoteMessage.html">RemoteMessage</a>&nbsp;message)</pre>
         <aside class="caution"><strong>This method is deprecated.</strong><br>
-          <p>FCM upstream messaging is decommissioned. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
+          <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
         </aside>
         <p>Sends <code>message</code> upstream to your app server. </p>
         <p>When there is an active connection the message will be sent immediately, otherwise the message will be queued up to the time to live (TTL) set in the message.</p>
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/messaging/FirebaseMessagingService.html	2024-11-13 17:59:02.985298936 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/messaging/FirebaseMessagingService.html	2024-11-13 17:56:59.392009536 +0000
@@ -112,7 +112,7 @@
             <td>
               <div><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/WorkerThread.html">WorkerThread</a><br><span><del><a href="/docs/reference/android/com/google/firebase/messaging/FirebaseMessagingService.html#onMessageSent(java.lang.String)">onMessageSent</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;msgId)</code></div>
               <p><strong>This method is deprecated.</strong>
-                <p>FCM upstream messaging is decommissioned.</p>
+                <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging.</p>
               </p>
             </td>
           </tr>
@@ -128,7 +128,7 @@
             <td>
               <div><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/WorkerThread.html">WorkerThread</a><br><span><del><a href="/docs/reference/android/com/google/firebase/messaging/FirebaseMessagingService.html#onSendError(java.lang.String,java.lang.Exception)">onSendError</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;msgId,&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Exception.html">Exception</a>&nbsp;exception)</code></div>
               <p><strong>This method is deprecated.</strong>
-                <p>FCM upstream messaging is decommissioned.</p>
+                <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging.</p>
               </p>
             </td>
           </tr>
@@ -2002,7 +2002,7 @@
         <h3 class="api-name" id="onMessageSent(java.lang.String)">onMessageSent</h3>
         <pre class="api-signature no-pretty-print">@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/WorkerThread.html">WorkerThread</a><br>public&nbsp;void&nbsp;<span><del><a href="/docs/reference/android/com/google/firebase/messaging/FirebaseMessagingService.html#onMessageSent(java.lang.String)">onMessageSent</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;msgId)</pre>
         <aside class="caution"><strong>This method is deprecated.</strong><br>
-          <p>FCM upstream messaging is decommissioned. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
+          <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
         </aside>
         <p>Called when an upstream message has been successfully sent to the GCM connection server.</p>
         <div class="devsite-table-wrapper">
@@ -2058,7 +2058,7 @@
         <h3 class="api-name" id="onSendError(java.lang.String,java.lang.Exception)">onSendError</h3>
         <pre class="api-signature no-pretty-print">@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/WorkerThread.html">WorkerThread</a><br>public&nbsp;void&nbsp;<span><del><a href="/docs/reference/android/com/google/firebase/messaging/FirebaseMessagingService.html#onSendError(java.lang.String,java.lang.Exception)">onSendError</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;msgId,&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Exception.html">Exception</a>&nbsp;exception)</pre>
         <aside class="caution"><strong>This method is deprecated.</strong><br>
-          <p>FCM upstream messaging is decommissioned. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
+          <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
         </aside>
         <p>Called when there was an error sending an upstream message.</p>
         <div class="devsite-table-wrapper">
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/messaging/RemoteMessage.html	2024-11-13 17:59:02.985298936 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/messaging/RemoteMessage.html	2024-11-13 17:56:59.392009536 +0000
@@ -213,7 +213,7 @@
             <td>
               <div><code><span><del><a href="/docs/reference/android/com/google/firebase/messaging/RemoteMessage.html#getTo()">getTo</a></del></span>()</code></div>
               <p><strong>This method is deprecated.</strong>
-                <p>FCM upstream messaging is decommissioned.</p>
+                <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging.</p>
               </p>
             </td>
           </tr>
@@ -616,7 +616,7 @@
         <h3 class="api-name" id="getTo()">getTo</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;<span><del><a href="/docs/reference/android/com/google/firebase/messaging/RemoteMessage.html#getTo()">getTo</a></del></span>()</pre>
         <aside class="caution"><strong>This method is deprecated.</strong><br>
-          <p>FCM upstream messaging is decommissioned. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
+          <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
         </aside>
         <p>Gets the message destination.</p>
       </div>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/messaging/FirebaseMessaging.html	2024-11-13 17:59:02.985298936 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/messaging/FirebaseMessaging.html	2024-11-13 17:56:59.384009437 +0000
@@ -96,7 +96,7 @@
             <td>
               <div><code><span><del><a href="/docs/reference/kotlin/com/google/firebase/messaging/FirebaseMessaging.html#send(com.google.firebase.messaging.RemoteMessage)">send</a></del></span>(message:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/messaging/RemoteMessage.html">RemoteMessage</a>)</code></div>
               <p><strong>This function is deprecated.</strong>
-                <p>FCM upstream messaging is decommissioned.</p>
+                <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging.</p>
               </p>
             </td>
           </tr>
@@ -272,7 +272,7 @@
         <h3 class="api-name" id="send(com.google.firebase.messaging.RemoteMessage)">send</h3>
         <pre class="api-signature no-pretty-print">fun&nbsp;<span><del><a href="/docs/reference/kotlin/com/google/firebase/messaging/FirebaseMessaging.html#send(com.google.firebase.messaging.RemoteMessage)">send</a></del></span>(message:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/messaging/RemoteMessage.html">RemoteMessage</a>):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
         <aside class="caution"><strong>This function is deprecated.</strong><br>
-          <p>FCM upstream messaging is decommissioned. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
+          <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
         </aside>
         <p>Sends <code>message</code> upstream to your app server. </p>
         <p>When there is an active connection the message will be sent immediately, otherwise the message will be queued up to the time to live (TTL) set in the message.</p>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/messaging/FirebaseMessagingService.html	2024-11-13 17:59:02.985298936 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/messaging/FirebaseMessagingService.html	2024-11-13 17:56:59.384009437 +0000
@@ -112,7 +112,7 @@
             <td>
               <div><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/WorkerThread.html">WorkerThread</a><br><span><del><a href="/docs/reference/kotlin/com/google/firebase/messaging/FirebaseMessagingService.html#onMessageSent(java.lang.String)">onMessageSent</a></del></span>(msgId:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>)</code></div>
               <p><strong>This function is deprecated.</strong>
-                <p>FCM upstream messaging is decommissioned.</p>
+                <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging.</p>
               </p>
             </td>
           </tr>
@@ -128,7 +128,7 @@
             <td>
               <div><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/WorkerThread.html">WorkerThread</a><br><span><del><a href="/docs/reference/kotlin/com/google/firebase/messaging/FirebaseMessagingService.html#onSendError(java.lang.String,java.lang.Exception)">onSendError</a></del></span>(msgId:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>,&nbsp;exception:&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Exception.html">Exception</a>)</code></div>
               <p><strong>This function is deprecated.</strong>
-                <p>FCM upstream messaging is decommissioned.</p>
+                <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging.</p>
               </p>
             </td>
           </tr>
@@ -2002,7 +2002,7 @@
         <h3 class="api-name" id="onMessageSent(java.lang.String)">onMessageSent</h3>
         <pre class="api-signature no-pretty-print">@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/WorkerThread.html">WorkerThread</a><br>fun&nbsp;<span><del><a href="/docs/reference/kotlin/com/google/firebase/messaging/FirebaseMessagingService.html#onMessageSent(java.lang.String)">onMessageSent</a></del></span>(msgId:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
         <aside class="caution"><strong>This function is deprecated.</strong><br>
-          <p>FCM upstream messaging is decommissioned. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
+          <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
         </aside>
         <p>Called when an upstream message has been successfully sent to the GCM connection server.</p>
         <div class="devsite-table-wrapper">
@@ -2058,7 +2058,7 @@
         <h3 class="api-name" id="onSendError(java.lang.String,java.lang.Exception)">onSendError</h3>
         <pre class="api-signature no-pretty-print">@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/WorkerThread.html">WorkerThread</a><br>fun&nbsp;<span><del><a href="/docs/reference/kotlin/com/google/firebase/messaging/FirebaseMessagingService.html#onSendError(java.lang.String,java.lang.Exception)">onSendError</a></del></span>(msgId:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>,&nbsp;exception:&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Exception.html">Exception</a>):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
         <aside class="caution"><strong>This function is deprecated.</strong><br>
-          <p>FCM upstream messaging is decommissioned. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
+          <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
         </aside>
         <p>Called when there was an error sending an upstream message.</p>
         <div class="devsite-table-wrapper">
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/messaging/RemoteMessage.html	2024-11-13 17:59:02.981298905 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/messaging/RemoteMessage.html	2024-11-13 17:56:59.384009437 +0000
@@ -172,7 +172,7 @@
             <td>
               <div><code><span><del><a href="/docs/reference/kotlin/com/google/firebase/messaging/RemoteMessage.html#getTo()">getTo</a></del></span>()</code></div>
               <p><strong>This function is deprecated.</strong>
-                <p>FCM upstream messaging is decommissioned.</p>
+                <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging.</p>
               </p>
             </td>
           </tr>
@@ -538,7 +538,7 @@
         <h3 class="api-name" id="getTo()">getTo</h3>
         <pre class="api-signature no-pretty-print">fun&nbsp;<span><del><a href="/docs/reference/kotlin/com/google/firebase/messaging/RemoteMessage.html#getTo()">getTo</a></del></span>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?</pre>
         <aside class="caution"><strong>This function is deprecated.</strong><br>
-          <p>FCM upstream messaging is decommissioned. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
+          <p>This function is actually <b>decommissioned</b> along with all of FCM upstream messaging. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
         </aside>
         <p>Gets the message destination.</p>
       </div>

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Test Results

 64 files   -  46   64 suites   - 46   6m 9s ⏱️ + 3m 55s
487 tests  - 481  487 ✅  - 481  0 💤 ±0  0 ❌ ±0 
980 runs   - 964  980 ✅  - 964  0 💤 ±0  0 ❌ ±0 

Results for commit 5634a2d. ± Comparison against base commit 9ae2606.

This pull request removes 968 and adds 487 tests. Note that renamed tests count towards both. 
com.google.firebase.perf.FirebasePerfRegistrarTest ‑ testGetComponents
com.google.firebase.perf.FirebasePerformanceTest ‑ firebasePerformanceInitialization_providesRcProvider_remoteConfigManagerIsSet
com.google.firebase.perf.FirebasePerformanceTest ‑ initFirebasePerformance_injectsMetadataIntoConfigResolver
com.google.firebase.perf.FirebasePerformanceTest ‑ initializeFirebasePerformance_emptyMetadataAndCache_metadataAndContextInjected
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsManifestTrue
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsManifestFalse
com.google.firebase.perf.FirebasePerformanceTest ‑ testAddingMoreThanMaxLocalAttributes
com.google.firebase.perf.FirebasePerformanceTest ‑ testBothManifestsAgree
…

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[24]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[22]
…

♻️ This comment has been updated with latest results.

@VinayGuthal VinayGuthal merged commit 3d6e8b2 into main Nov 13, 2024
32 of 33 checks passed
@VinayGuthal VinayGuthal deleted the gsakakihara/javadoc branch November 13, 2024 18:24
VinayGuthal pushed a commit that referenced this pull request Nov 13, 2024
@gsakakihara @VinayGuthal
Update upstream methods to indicate they are now decommissioned. (#6508)
f5411e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsakakihara @VinayGuthal @google-oss-bot