Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OrderDirection support #6307

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add OrderDirection support #6307

merged 1 commit into from
Sep 25, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 25, 2024 •
edited
Loading

Add OrderDirection enum support.

For example:

# Note how the query takes `OrderDirection` as a variable
# and passes it on to the `orderBy` argument of `foos`.
query GetAllFoos($dir: OrderDirection) {
  foos(orderBy: { bar: $dir }) {
    bar
  }
}

A follow-up PR, #6308, will add generated SDK tests once the data connect toolkit is released with OrderDirection support in Android codegen.

Googlers see b/369348331 for details.

@dconeybe dconeybe self-assigned this Sep 25, 2024
@dconeybe dconeybe changed the title Add OrderDirection support; a follow-up PR will add generated SDK tes… Add OrderDirection support Sep 25, 2024
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 25, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-dataconnect

    Overall coverage changed from ? (a95da3f) to 10.44% (4c73ae8) by ?.

    53 individual files with coverage change

    FilenameBase (a95da3f)Merge (4c73ae8)Diff
    AlphanumericStringUtil.kt?0.00%?
    AnyValue.kt?0.00%?
    AnyValueSerializer.kt?0.00%?
    Comparisons.kt?0.00%?
    ConnectorConfig.kt?33.33%?
    CoroutineExceptionHandler.kt?50.00%?
    DataConnectAppCheck.kt?0.00%?
    DataConnectAuth.kt?0.00%?
    DataConnectCredentialsTokenManager.kt?0.00%?
    DataConnectError.kt?0.00%?
    DataConnectException.kt?0.00%?
    DataConnectGrpcClient.kt?0.00%?
    DataConnectGrpcMetadata.kt?65.82%?
    DataConnectGrpcRPCs.kt?0.00%?
    DataConnectSettings.kt?33.33%?
    DataConnectUntypedData.kt?0.00%?
    DataConnectUntypedVariables.kt?0.00%?
    DateSerializer.kt?0.00%?
    FirebaseDataConnect.kt?50.00%?
    FirebaseDataConnectFactory.kt?29.17%?
    FirebaseDataConnectImpl.kt?38.05%?
    FirebaseDataConnectRegistrar.kt?100.00%?
    GeneratedConnector.kt?0.00%?
    GeneratedMutation.kt?0.00%?
    GeneratedOperation.kt?0.00%?
    GeneratedQuery.kt?0.00%?
    Globals.kt?0.00%?
    LiveQueries.kt?0.00%?
    LiveQuery.kt?0.00%?
    Logger.kt?52.17%?
    LogLevel.kt?100.00%?
    MutationRef.kt?0.00%?
    MutationRefImpl.kt?22.45%?
    NullableReference.kt?40.00%?
    NullOutputStream.kt?0.00%?
    OperationRef.kt?0.00%?
    OperationRefImpl.kt?20.93%?
    OptionalVariable.kt?0.00%?
    ProtoStructDecoder.kt?0.00%?
    ProtoStructEncoder.kt?0.00%?
    ProtoUtil.kt?0.00%?
    QueryManager.kt?0.00%?
    QueryRef.kt?0.00%?
    QueryRefImpl.kt?32.26%?
    QuerySubscription.kt?0.00%?
    QuerySubscriptionImpl.kt?0.00%?
    QuerySubscriptionInternal.kt?0.00%?
    ReferenceCounted.kt?0.00%?
    RegisteredDataDeserialzer.kt?0.00%?
    SequencedReference.kt?0.00%?
    SuspendingLazy.kt?31.58%?
    TimestampSerializer.kt?0.00%?
    UUIDSerializer.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kspzWQ77L9.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

Unit Test Results

  48 files   -      970    48 suites   - 970   1m 23s ⏱️ - 35m 35s
484 tests  -   5 326  484 ✔️  -   5 305  0 💤  - 21  0 ❌ ±0 
968 runs   - 10 737  968 ✔️  - 10 695  0 💤  - 42  0 ❌ ±0 

Results for commit 128b537. ± Comparison against base commit a95da3f.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 25, 2024 •
edited
Loading

Size Report 1

Affected Products

  • firebase-dataconnect

    TypeBase (a95da3f)Merge (4c73ae8)Diff
    aar688 kB688 kB+257 B (+0.0%)
    apk (release)9.99 MB9.99 MB-20 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4zJfYGyTym.html

@dconeybe dconeybe mentioned this pull request Sep 25, 2024
Merged
Base automatically changed from dataconnect to main September 25, 2024 16:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-dataconnect 
### {{firebase_data_connect}} version 16.0.0-beta01 {: #dataconnect_v16-0-0-beta01}

* {{feature}} Initial release of the Data Connect SDK (public preview). Learn how to
  [get started](https://firebase.google.com/docs/data-connect/android-sdk)
  with the SDK in your app.

* {{feature}} Added App Check support.
  (GitHub [#6176](//github.com/firebase/firebase-android-sdk/issues/6176){: .external})

* {{feature}} Added `AnyValue` to support the `Any` custom GraphQL scalar type.
  (GitHub [#6285](//github.com/firebase/firebase-android-sdk/issues/6285){: .external})

* {{feature}} Added `OrderDirection` enum support.
  (GitHub [#6307](//github.com/firebase/firebase-android-sdk/issues/6307){: .external})

* {{feature}} Added ability to specify `SerializersModule` when serializing.
  (GitHub [#6297](//github.com/firebase/firebase-android-sdk/issues/6297){: .external})

* {{feature}} Added `CallerSdkType`, which enables tracking of the generated SDK usage.
  (GitHub [#6298](//github.com/firebase/firebase-android-sdk/issues/6298){: .external} and
  GitHub [#6179](//github.com/firebase/firebase-android-sdk/issues/6179){: .external})

* {{changed}} Changed gRPC proto package to v1beta (was v1alpha).
  (GitHub [#6299](//github.com/firebase/firebase-android-sdk/issues/6299){: .external})

* {{changed}} Added `equals` and `hashCode` methods to `GeneratedConnector`.
  (GitHub [#6177](//github.com/firebase/firebase-android-sdk/issues/6177){: .external})

@dconeybe
Add OrderDirection support; a follow-up PR will add generated SDK tes…
128b537 
…ts once the data connect toolkit is released with OrderDirection support in Android codegen
@dconeybe dconeybe force-pushed the dconeybe/dataconnect/OrderDirection branch from 7440ec6 to 128b537 Compare September 25, 2024 16:35
@dconeybe dconeybe merged commit cb132ab into main Sep 25, 2024
38 of 39 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/OrderDirection branch September 25, 2024 16:45
emilypgoogle pushed a commit that referenced this pull request Sep 25, 2024
@dconeybe @emilypgoogle
Add OrderDirection support (#6307)
a28de50
emilypgoogle pushed a commit that referenced this pull request Sep 25, 2024
@dconeybe @emilypgoogle
Add OrderDirection support (#6307)
ebdd577
@firebase firebase locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joehan joehan joehan approved these changes

@aashishpatil-g aashishpatil-g aashishpatil-g approved these changes

@maneesht maneesht maneesht approved these changes

@cherylEnkidu cherylEnkidu Awaiting requested review from cherylEnkidu

Assignees

@dconeybe dconeybe

Labels
main-merge-ack size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dconeybe @google-oss-bot @joehan @maneesht @aashishpatil-g