Skip to content

Adds unit test for SessionLifecycleClient. #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryanatkinson merged 5 commits into from
Oct 26, 2023
Merged

Adds unit test for SessionLifecycleClient. #5475

bryanatkinson merged 5 commits into from
Oct 26, 2023

Conversation

@bryanatkinson
Copy link
Contributor

@bryanatkinson bryanatkinson commented Oct 26, 2023 •
edited
Loading

No description provided.

@bryanatkinson
Refactors the SessionLifecycleClient to be a class instead ofan objec…
52e4e9b 
…t, and pulls the service binding into a different class to improve testability of the client.
@bryanatkinson
Updating filter/sort logic to be more clear.
c5b0b92
@bryanatkinson
Adds unit test for SessionLifecycleClient. This required pulling the …
8d99cf1 
…binding logic into a separate class so we can provide different bindings in unit tests.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 26, 2023

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@bryanatkinson bryanatkinson changed the title Adds unit test for SessionLifecycleClient. This required pulling the … Adds unit test for SessionLifecycleClient. Oct 26, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 26, 2023 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (c5b0b92) and merge commit (a219b1c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HSysMIOX3n.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

Unit Test Results

   112 files   - 11     112 suites   - 11   3m 13s ⏱️ -19s
   993 tests  - 46     993 ✔️  - 46  0 💤 ±0  0 ❌ ±0 
1 986 runs   - 46  1 986 ✔️  - 46  0 💤 ±0  0 ❌ ±0 

Results for commit 900b820. ± Comparison against base commit c5b0b92.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 26, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (c5b0b92)Merge (a219b1c)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-sessions

    TypeBase (c5b0b92)Merge (a219b1c)Diff
    aar?151 kB? (?)
    apk (aggressive)?373 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JIgCE7Ru0p.html

Base automatically changed from sessions-client-class to sessions-nine October 26, 2023 15:43
@bryanatkinson bryanatkinson merged commit 7a1b9f7 into sessions-nine Oct 26, 2023
@bryanatkinson bryanatkinson deleted the sessions-client-test branch October 26, 2023 15:44
@firebase firebase locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrothfeder jrothfeder jrothfeder approved these changes

@mrober mrober mrober approved these changes

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bryanatkinson @google-oss-bot @jrothfeder @mrober