Skip to content

Refactors the SessionLifecycleClient to be a class instead ofan objec… #5472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryanatkinson merged 2 commits into from
Oct 26, 2023
Merged

Refactors the SessionLifecycleClient to be a class instead ofan objec… #5472

bryanatkinson merged 2 commits into from
Oct 26, 2023

Conversation

@bryanatkinson
Copy link
Contributor

@bryanatkinson bryanatkinson commented Oct 23, 2023

…t, and pulls the service binding into a different class to improve testability of the client.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 23, 2023

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 23, 2023 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (6ed2dbb) and merge commit (cc45b8d).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/N5bEa9JtEe.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

Unit Test Results

   123 files   - 15     123 suites   - 15   3m 32s ⏱️ - 1m 15s
1 039 tests ±  0  1 039 ✔️ +  1  0 💤 ±0  0 ❌  - 1 
2 032 runs   - 54  2 032 ✔️  - 53  0 💤 ±0  0 ❌  - 1 

Results for commit c5b0b92. ± Comparison against base commit 6ed2dbb.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 23, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (6ed2dbb)Merge (cc45b8d)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-sessions

    TypeBase (6ed2dbb)Merge (cc45b8d)Diff
    aar?151 kB? (?)
    apk (aggressive)?373 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/erFSpfqc4V.html

@bryanatkinson
Refactors the SessionLifecycleClient to be a class instead ofan objec…
52e4e9b 
…t, and pulls the service binding into a different class to improve testability of the client.
@bryanatkinson bryanatkinson merged commit 26990ac into sessions-nine Oct 26, 2023
@bryanatkinson bryanatkinson deleted the sessions-client-class branch October 26, 2023 15:43
@firebase firebase locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrothfeder jrothfeder jrothfeder approved these changes

@mrober mrober mrober approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bryanatkinson @google-oss-bot @jrothfeder @mrober