Skip to content

Moves SessionFirelogPublisher and SessionDatastore behind an interfac… #5461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryanatkinson merged 3 commits into from
Oct 20, 2023
Merged

Moves SessionFirelogPublisher and SessionDatastore behind an interfac… #5461

bryanatkinson merged 3 commits into from
Oct 20, 2023

Conversation

@bryanatkinson
Copy link
Contributor

@bryanatkinson bryanatkinson commented Oct 20, 2023

…e and managed by the Registrar in order to improve testability in the SessionLifecycleService.

@bryanatkinson
Moves SessionFirelogPublisher and SessionDatastore behind an interfac…
81c49f3 
…e and managed by the Registrar in order to improve testability in the SessionLifecycleService.
@bryanatkinson
Formatting
def8db1
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 20, 2023

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 20, 2023 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (746da95) and merge commit (fa47bbf).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/L7DRZ4wPer.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

Unit Test Results

22 files  +22  22 suites  +22   46s ⏱️ +46s
46 tests +46  46 ✔️ +46  0 💤 ±0  0 ❌ ±0 
92 runs  +92  92 ✔️ +92  0 💤 ±0  0 ❌ ±0 

Results for commit d1e2a01. ± Comparison against base commit 746da95.

♻️ This comment has been updated with latest results.

@bryanatkinson bryanatkinson merged commit 5c8bf24 into sessions-nine Oct 20, 2023
@bryanatkinson bryanatkinson deleted the sessions-firelog-interface branch October 20, 2023 20:24
@firebase firebase locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrothfeder jrothfeder jrothfeder approved these changes

@mrober mrober mrober approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bryanatkinson @google-oss-bot @jrothfeder @mrober