Skip to content

Replaces info level log messages with debug messages and adds a coupl… #5442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryanatkinson merged 1 commit into from
Oct 18, 2023
Merged

Replaces info level log messages with debug messages and adds a coupl… #5442

bryanatkinson merged 1 commit into from
Oct 18, 2023

Conversation

@bryanatkinson
Copy link
Contributor

@bryanatkinson bryanatkinson commented Oct 18, 2023

…e of new log lines.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 18, 2023

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@bryanatkinson bryanatkinson merged commit 1a70bdc into sessions-nine Oct 18, 2023
@bryanatkinson bryanatkinson deleted the sessions-logs branch October 18, 2023 15:36
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 18, 2023

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (f00c59e) to 58.93% (931b730) by ?.

    26 individual files with coverage change

    FilenameBase (f00c59e)Merge (931b730)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?0.00%?
    Dispatchers.kt?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?92.00%?
    FirebaseSessionsRegistrar.kt?76.27%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.06%?
    RemoteSettingsFetcher.kt?65.85%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.78%?
    SessionFirelogPublisher.kt?83.33%?
    SessionGenerator.kt?20.83%?
    SessionLifecycleClient.kt?0.00%?
    SessionLifecycleService.kt?0.00%?
    SessionsActivityLifecycleCallbacks.kt?0.00%?
    SessionsSettings.kt?59.62%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/coPtopKDXN.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 18, 2023

Size Report 1

Affected Products

  • base

    TypeBase (f00c59e)Merge (931b730)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-installations

    TypeBase (f00c59e)Merge (931b730)Diff
    aar?58.5 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)

  • firebase-installations-interop

    TypeBase (f00c59e)Merge (931b730)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)

  • firebase-sessions

    TypeBase (f00c59e)Merge (931b730)Diff
    aar?142 kB? (?)
    apk (aggressive)?367 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/W91jA7jzl2.html

@firebase firebase locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrober mrober mrober approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bryanatkinson @google-oss-bot @mrober