Skip to content

Refactors SessionLifecycleService to make the message handler static … #5434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryanatkinson merged 1 commit into from
Oct 17, 2023
Merged

Refactors SessionLifecycleService to make the message handler static … #5434

bryanatkinson merged 1 commit into from
Oct 17, 2023

Conversation

@bryanatkinson
Copy link
Contributor

@bryanatkinson bryanatkinson commented Oct 17, 2023

…and use the same Messenger instance for every client. This makes sure that all state manipulation happens on the same looper, so we can get rid of the LinkedBlockingQueue or worry about volatile booleans.

@bryanatkinson
Refactors SessionLifecycleService to make the message handler static …
d6e2f41 
…and use the same Messenger instance for every client. This makes sure that all state manipulation happens on the same looper, so we can get rid of the LinkedBlockingQueue or worry about volatile booleans.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 17, 2023

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 17, 2023

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (cd58103) to 59.25% (825ab8e) by ?.

    26 individual files with coverage change

    FilenameBase (cd58103)Merge (825ab8e)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?91.30%?
    FirebaseSessionsRegistrar.kt?71.67%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.06%?
    RemoteSettingsFetcher.kt?65.85%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.78%?
    SessionFirelogPublisher.kt?83.33%?
    SessionGenerator.kt?87.50%?
    SessionInitiateListener.kt?0.00%?
    SessionInitiator.kt?74.19%?
    SessionLifecycleClient.kt?0.00%?
    SessionLifecycleService.kt?0.00%?
    SessionsSettings.kt?59.62%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/U2BrHOTEOi.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Unit Test Results

     83 files       83 suites   3m 4s ⏱️
1 044 tests 1 041 ✔️ 0 💤 3 ❌
1 113 runs  1 110 ✔️ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit d6e2f41.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 17, 2023

Size Report 1

Affected Products

  • base

    TypeBase (cd58103)Merge (825ab8e)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-installations

    TypeBase (cd58103)Merge (825ab8e)Diff
    aar?58.8 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)

  • firebase-installations-interop

    TypeBase (cd58103)Merge (825ab8e)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)

  • firebase-sessions

    TypeBase (cd58103)Merge (825ab8e)Diff
    aar?148 kB? (?)
    apk (aggressive)?372 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SdRuEJvnXD.html

@bryanatkinson bryanatkinson merged commit 113b771 into sessions-nine Oct 17, 2023
@bryanatkinson bryanatkinson deleted the sessions-service-static-handler branch October 17, 2023 18:09
@firebase firebase locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrothfeder jrothfeder jrothfeder approved these changes

@mrober mrober Awaiting requested review from mrober

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bryanatkinson @google-oss-bot @jrothfeder