Skip to content

Updates the service to run on a looper on it's own thread and not use… #5431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryanatkinson merged 1 commit into from
Oct 17, 2023
Merged

Updates the service to run on a looper on it's own thread and not use… #5431

bryanatkinson merged 1 commit into from
Oct 17, 2023

Conversation

@bryanatkinson
Copy link
Contributor

@bryanatkinson bryanatkinson commented Oct 17, 2023

… the MainLooper which is the application main thread and so could interfere with things there. Also fixes issue with missing import.

@bryanatkinson
Updates the service to run on a looper on it's own thread and not use…
1acd4af 
… the MainLooper which is the application main thread and so could interfere with things there. Also fixes issue with missing import.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 17, 2023

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 17, 2023

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (771ffb7) to 59.83% (cf2a71c) by ?.

    26 individual files with coverage change

    FilenameBase (771ffb7)Merge (cf2a71c)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?91.30%?
    FirebaseSessionsRegistrar.kt?71.67%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.06%?
    RemoteSettingsFetcher.kt?65.85%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.78%?
    SessionFirelogPublisher.kt?83.33%?
    SessionGenerator.kt?87.50%?
    SessionInitiateListener.kt?0.00%?
    SessionInitiator.kt?74.19%?
    SessionLifecycleClient.kt?0.00%?
    SessionLifecycleService.kt?0.00%?
    SessionsSettings.kt?59.62%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1j62MK23Fr.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Unit Test Results

     83 files       83 suites   2m 34s ⏱️
1 044 tests 1 043 ✔️ 0 💤 1 ❌
1 113 runs  1 112 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 1acd4af.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 17, 2023

Size Report 1

Affected Products

  • base

    TypeBase (771ffb7)Merge (cf2a71c)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-installations

    TypeBase (771ffb7)Merge (cf2a71c)Diff
    aar?58.8 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)

  • firebase-installations-interop

    TypeBase (771ffb7)Merge (cf2a71c)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)

  • firebase-sessions

    TypeBase (771ffb7)Merge (cf2a71c)Diff
    aar?148 kB? (?)
    apk (aggressive)?371 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ths30Qv3aZ.html

jrothfeder
jrothfeder approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@jrothfeder jrothfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@bryanatkinson bryanatkinson merged commit cd58103 into sessions-nine Oct 17, 2023
@bryanatkinson bryanatkinson deleted the sessions-service-looper branch October 17, 2023 15:33
@firebase firebase locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrothfeder jrothfeder jrothfeder approved these changes

@mrober mrober mrober approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bryanatkinson @google-oss-bot @jrothfeder @mrober