Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only support the default Firebase app #5422

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Only support the default Firebase app #5422

merged 1 commit into from
Oct 17, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Oct 13, 2023

This will make it safe to call Firebase.app any time from anywhere in this SDK.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (716b65c) to 59.92% (2da83b2) by ?.

    26 individual files with coverage change

    FilenameBase (716b65c)Merge (2da83b2)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?91.30%?
    FirebaseSessionsRegistrar.kt?74.07%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.06%?
    RemoteSettingsFetcher.kt?65.85%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.78%?
    SessionFirelogPublisher.kt?70.59%?
    SessionGenerator.kt?87.50%?
    SessionInitiateListener.kt?0.00%?
    SessionInitiator.kt?74.19%?
    SessionLifecycleClient.kt?0.00%?
    SessionLifecycleService.kt?0.00%?
    SessionsSettings.kt?59.62%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AedGu897O2.html

@github-actions
Copy link
Contributor

Unit Test Results

     83 files       83 suites   2m 37s ⏱️
1 044 tests 1 043 ✔️ 0 💤 1 ❌
1 113 runs  1 112 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit cacd798.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (716b65c)Merge (2da83b2)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-installations

    TypeBase (716b65c)Merge (2da83b2)Diff
    aar?58.8 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)

  • firebase-installations-interop

    TypeBase (716b65c)Merge (2da83b2)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)

  • firebase-sessions

    TypeBase (716b65c)Merge (2da83b2)Diff
    aar?142 kB? (?)
    apk (aggressive)?367 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/55UmEgV1HZ.html

@mrober mrober merged commit bcca211 into sessions-nine Oct 17, 2023
18 of 23 checks passed
@mrober mrober deleted the sessions-nine-default branch October 17, 2023 13:27
@firebase firebase locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryanatkinson bryanatkinson bryanatkinson approved these changes

@jrothfeder jrothfeder Awaiting requested review from jrothfeder

Assignees
No one assigned
Labels
no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrober @google-oss-bot @bryanatkinson