Wire datastore in to FirebaseLifecycleService #5420
Conversation
jrothfeder
changed the title
| */ | ||
| internal class SessionLifecycleService : Service() { | ||
| internal class SessionLifecycleService( | ||
| private var datastore: SessionDatastore = SessionDatastore(Firebase.app.applicationContext)) |
There was a problem hiding this comment.
Is Firebase.app guaranteed to exist when this is constructed?
There was a problem hiding this comment.
I think so. Isn't it created first?
| updateSessionStorage(null, timeMs) | ||
| } | ||
|
|
||
| private fun updateSessionStorage(sessionId: String?, timeMs: Long) { |
There was a problem hiding this comment.
You could say sessionId: String = null here instead of the manual overloading with and without sessionId.
| // Send the value from the datastore before the first foregrounding it exists | ||
| val sessionData = currentSessionFromDatastore.get() | ||
| if (sessionData != null) { | ||
| sessionData.sessionId?.let { sendSessionToClient(client, it) } |
There was a problem hiding this comment.
sessionData?.sessionId?.let will remove the if null check.
| * The callback class that will be used to receive updated session events from the | ||
| * [SessionLifecycleService]. | ||
| */ | ||
| // TODO(rothbutter) should we use the main looper or is there one available in this SDK? |
There was a problem hiding this comment.
This is fine for now. I'll make the firebase common ones easy to access.
| } | ||
| } | ||
| lastMsgTimeMs = msg.getWhen() | ||
| updateSessionStorage(lastMsgTimeMs) // TODO(rothbutter) don't think we need this, eh? |
There was a problem hiding this comment.
Not sure. If we don't, that will be much better. I am a bit worried about using a timestamp like this, because clocks can change with daylight savings and leap seconds and whatever. In the WallClock object there is elapsedRealtime which is a monotonic increasing clock so won't go backwards no matter what happens on the calendar. Otherwise an hour forward might make everything a new session.
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
4 participants
No description provided.