Skip to content

Make SessionGenerator injectable #5412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrober merged 3 commits into from
Oct 13, 2023
Merged

Make SessionGenerator injectable #5412

mrober merged 3 commits into from
Oct 13, 2023

Conversation

@mrober
Copy link
Contributor

@mrober mrober commented Oct 12, 2023

Make SessionGenerator injectable. Also made WallClock an object to avoid needing to pass it around. Moved collectEvents out of SessionGenerator since it will need to be handled in the service.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2023

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (2a7e354) to 60.05% (fee06d0) by ?.

    27 individual files with coverage change

    FilenameBase (2a7e354)Merge (fee06d0)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?91.30%?
    FirebaseSessionsRegistrar.kt?77.55%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.06%?
    RemoteSettingsFetcher.kt?65.85%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.78%?
    SessionFirelogPublisher.kt?66.67%?
    SessionGenerator.kt?84.00%?
    SessionInitiateListener.kt?0.00%?
    SessionInitiator.kt?74.19%?
    SessionLifecycleClient.kt?0.00%?
    SessionLifecycleService.kt?0.00%?
    SessionMaintainer.kt?0.00%?
    SessionsSettings.kt?70.45%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9gXSD3KcUt.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Unit Test Results

     83 files       83 suites   2m 45s ⏱️
1 044 tests 1 042 ✔️ 0 💤 2 ❌
1 113 runs  1 111 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 0b4eb93.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2023

Size Report 1

Affected Products

  • base

    TypeBase (2a7e354)Merge (fee06d0)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-installations

    TypeBase (2a7e354)Merge (fee06d0)Diff
    aar?58.8 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)

  • firebase-installations-interop

    TypeBase (2a7e354)Merge (fee06d0)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)

  • firebase-sessions

    TypeBase (2a7e354)Merge (fee06d0)Diff
    aar?141 kB? (?)
    apk (aggressive)?366 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/n01rktpHgN.html

@mrober mrober merged commit 3cb8371 into sessions-nine Oct 13, 2023
@mrober mrober deleted the sessions-nine-deps branch October 13, 2023 10:10
@firebase firebase locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrothfeder jrothfeder jrothfeder approved these changes

@bryanatkinson bryanatkinson bryanatkinson approved these changes

Assignees

No one assigned

Labels

no-changelog size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrober @google-oss-bot @jrothfeder @bryanatkinson