Skip to content

Rename SessionCoordinator to SessionFirelogPublisher and add getInstance so it can be accessed from a bound service. #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrothfeder merged 3 commits into from
Oct 12, 2023
Merged

Rename SessionCoordinator to SessionFirelogPublisher and add getInstance so it can be accessed from a bound service. #5407

jrothfeder merged 3 commits into from
Oct 12, 2023

Conversation

@jrothfeder
Copy link
Contributor

@jrothfeder jrothfeder commented Oct 12, 2023

No description provided.

Rename SessionCoordinator to SessionFirelogPublisher and add `get…
6b39369 
…Instance` so it can be accessed from a bound service.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@jrothfeder jrothfeder changed the base branch from master to sessions-nine October 12, 2023 17:57
@jrothfeder jrothfeder changed the title Firelog writer Rename SessionCoordinator to SessionFirelogPublisher and add getInstance so it can be accessed from a bound service. Oct 12, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (e80929f) to 59.95% (d057829) by ?.

    27 individual files with coverage change

    FilenameBase (e80929f)Merge (d057829)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?91.30%?
    FirebaseSessionsRegistrar.kt?76.19%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.06%?
    RemoteSettingsFetcher.kt?65.85%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.78%?
    SessionFirelogPublisher.kt?66.67%?
    SessionGenerator.kt?91.67%?
    SessionInitiateListener.kt?0.00%?
    SessionInitiator.kt?74.19%?
    SessionLifecycleClient.kt?0.00%?
    SessionLifecycleService.kt?0.00%?
    SessionMaintainer.kt?0.00%?
    SessionsSettings.kt?70.45%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jd5q10nxJv.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Unit Test Results

     83 files  +    5       83 suites  +5   2m 37s ⏱️ - 2m 33s
1 044 tests +781  1 043 ✔️ +781  0 💤 ±0  1 ❌ ±0 
1 113 runs  +719  1 112 ✔️ +719  0 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 6b39369. ± Comparison against base commit 98b744a.

This pull request removes 263 and adds 1044 tests. Note that renamed tests count towards both. 
com.google.firebase.appcheck.FirebaseAppCheckRegistrarTest ‑ testGetComponents
com.google.firebase.appcheck.FirebaseAppCheckTest ‑ testGetInstance_defaultFirebaseAppName_matchesDefaultGetter
com.google.firebase.appcheck.FirebaseAppCheckTest ‑ testGetInstance_otherFirebaseAppName_doesNotMatch
com.google.firebase.appcheck.debug.DebugAppCheckProviderFactoryTest ‑ testGetInstance_callTwice_sameInstance
com.google.firebase.appcheck.debug.FirebaseAppCheckDebugRegistrarTest ‑ testGetComponents
com.google.firebase.appcheck.debug.internal.DebugAppCheckProviderTest ‑ exchangeDebugToken_onFailure_setsTaskException
com.google.firebase.appcheck.debug.internal.DebugAppCheckProviderTest ‑ exchangeDebugToken_onSuccess_setsTaskResult
com.google.firebase.appcheck.debug.internal.DebugAppCheckProviderTest ‑ testDetermineDebugSecret_noStoredSecret_createsNewSecret
com.google.firebase.appcheck.debug.internal.DebugAppCheckProviderTest ‑ testDetermineDebugSecret_storedSecret_usesExistingSecret
com.google.firebase.appcheck.debug.internal.DebugAppCheckProviderTest ‑ testPublicConstructor_nullFirebaseApp_expectThrows
…

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2023

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.SessionDatastoreKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@jrothfeder jrothfeder merged commit 2a7e354 into sessions-nine Oct 12, 2023
@jrothfeder jrothfeder deleted the firelog-writer branch October 12, 2023 18:23
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2023

Size Report 1

Affected Products

  • base

    TypeBase (e80929f)Merge (d057829)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-installations

    TypeBase (e80929f)Merge (d057829)Diff
    aar?58.8 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)

  • firebase-installations-interop

    TypeBase (e80929f)Merge (d057829)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)

  • firebase-sessions

    TypeBase (e80929f)Merge (d057829)Diff
    aar?140 kB? (?)
    apk (aggressive)?366 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ltJqRlRvfw.html

@firebase firebase locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryanatkinson bryanatkinson bryanatkinson approved these changes

@mrober mrober mrober approved these changes

Assignees

No one assigned

Labels

no-changelog size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jrothfeder @google-oss-bot @bryanatkinson @mrober