Skip to content

New datastore for holding session id and timestamp #5399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrothfeder merged 3 commits into from
Oct 11, 2023
Merged

New datastore for holding session id and timestamp #5399

jrothfeder merged 3 commits into from
Oct 11, 2023

Conversation

@jrothfeder
Copy link
Contributor

@jrothfeder jrothfeder commented Oct 11, 2023

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (f85056c) to 62.52% (f9da63b) by ?.

    25 individual files with coverage change

    FilenameBase (f85056c)Merge (f9da63b)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?91.30%?
    FirebaseSessionsRegistrar.kt?78.13%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.06%?
    RemoteSettingsFetcher.kt?65.85%?
    SafeCollector.common.kt?0.00%?
    SessionCoordinator.kt?75.00%?
    SessionDataService.kt?0.00%?
    SessionDatastore.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.78%?
    SessionGenerator.kt?91.67%?
    SessionInitiateListener.kt?0.00%?
    SessionInitiator.kt?74.19%?
    SessionMaintainer.kt?0.00%?
    SessionsSettings.kt?70.45%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Q4iTSVs8sD.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2023

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.FirebaseSessionsData [AddedClass]
error: Added class com.google.firebase.sessions.SessionDatastore [AddedClass]
error: Added class com.google.firebase.sessions.SessionDatastoreKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

Unit Test Results

     83 files       83 suites   3m 10s ⏱️
1 044 tests 1 043 ✔️ 0 💤 1 ❌
1 113 runs  1 112 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit e1d58f8.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2023

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.SessionDatastoreKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2023

The public api surface has changed for the subproject firebase-sessions:
error: Added class com.google.firebase.sessions.SessionDatastoreKt [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@jrothfeder jrothfeder merged commit 8e2255c into sessions-nine Oct 11, 2023
@jrothfeder jrothfeder deleted the sessions-datastore branch October 11, 2023 19:37
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2023

Size Report 1

Affected Products

  • base

    TypeBase (f85056c)Merge (f9da63b)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-installations

    TypeBase (f85056c)Merge (f9da63b)Diff
    aar?58.8 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)

  • firebase-installations-interop

    TypeBase (f85056c)Merge (f9da63b)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)

  • firebase-sessions

    TypeBase (f85056c)Merge (f9da63b)Diff
    aar?136 kB? (?)
    apk (aggressive)?366 kB? (?)
    apk (release)?2.07 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fThShWJvy9.html

@firebase firebase locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrober mrober mrober approved these changes

@bryanatkinson bryanatkinson Awaiting requested review from bryanatkinson

Assignees

No one assigned

Labels

no-changelog size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jrothfeder @google-oss-bot @mrober