Skip to content

Introduces a SessionDataService which is bound to by clients in each … #5397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryanatkinson merged 3 commits into from
Oct 11, 2023
Merged

Introduces a SessionDataService which is bound to by clients in each … #5397

bryanatkinson merged 3 commits into from
Oct 11, 2023

Conversation

@bryanatkinson
Copy link
Contributor

@bryanatkinson bryanatkinson commented Oct 11, 2023

Introduces a new SessionDataService that is bound to by each process and used to deliver session-ids.

@bryanatkinson
Introduces a SessionDataService which is bound to by clients in each …
00839eb 
…process for creating and pushing session ids.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2023

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (5e93dd1) to 65.29% (153fd12) by ?.

    22 individual files with coverage change

    FilenameBase (5e93dd1)Merge (153fd12)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?91.30%?
    FirebaseSessionsRegistrar.kt?78.13%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.06%?
    RemoteSettingsFetcher.kt?65.85%?
    SessionCoordinator.kt?75.00%?
    SessionDataService.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.78%?
    SessionGenerator.kt?91.67%?
    SessionInitiateListener.kt?0.00%?
    SessionInitiator.kt?74.19%?
    SessionMaintainer.kt?0.00%?
    SessionsSettings.kt?70.45%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OQwNrz1gNA.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

Unit Test Results

     83 files       83 suites   2m 33s ⏱️
1 044 tests 1 043 ✔️ 0 💤 1 ❌
1 113 runs  1 112 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit d4134ff.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (5e93dd1)Merge (153fd12)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-installations

    TypeBase (5e93dd1)Merge (153fd12)Diff
    aar?58.8 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)

  • firebase-installations-interop

    TypeBase (5e93dd1)Merge (153fd12)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)

  • firebase-sessions

    TypeBase (5e93dd1)Merge (153fd12)Diff
    aar?121 kB? (?)
    apk (aggressive)?365 kB? (?)
    apk (release)?2.07 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AIuouYaKm3.html

mrober
mrober reviewed Oct 11, 2023
View reviewed changes
firebase-sessions/src/main/AndroidManifest.xml Outdated

<application>
<service
android:name=".SessionDataService"
Copy link
Contributor

@mrober mrober Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this . carry on to the app when the manifests get merged? Will this have a different name for every app depending on it's app id? Or will it always be ...firebase-sessions.SessionDataService ?

Copy link
Contributor Author

@bryanatkinson bryanatkinson Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see it show up as com.google.firebase.sessions.SessionDataService in stack traces when running in an app, but I'll make this fully qualified like the other one.

mrober
mrober approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@mrober mrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM knowing this is still for debugging

@bryanatkinson bryanatkinson merged commit f85056c into sessions-nine Oct 11, 2023
@bryanatkinson bryanatkinson deleted the sessions-bound-service branch October 11, 2023 19:13
@firebase firebase locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrober mrober mrober approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bryanatkinson @google-oss-bot @mrober