Skip to content

Setup scaffolding for SessionMaintainer #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrober merged 1 commit into from
Oct 10, 2023
Merged

Setup scaffolding for SessionMaintainer #5393

mrober merged 1 commit into from
Oct 10, 2023

Conversation

@mrober
Copy link
Contributor

@mrober mrober commented Oct 10, 2023

No description provided.

@mrober mrober requested a review from jrothfeder October 10, 2023 20:14
@mrober mrober merged commit 2c30305 into sessions-nine Oct 10, 2023
@mrober mrober deleted the sessions-nine-maintainer branch October 10, 2023 20:16
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 10, 2023

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (a53ab64) to 74.80% (bc35cd2) by ?.

    21 individual files with coverage change

    FilenameBase (a53ab64)Merge (bc35cd2)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?91.30%?
    FirebaseSessionsRegistrar.kt?78.13%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.06%?
    RemoteSettingsFetcher.kt?65.85%?
    SessionCoordinator.kt?75.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.78%?
    SessionGenerator.kt?91.67%?
    SessionInitiateListener.kt?0.00%?
    SessionInitiator.kt?74.19%?
    SessionMaintainer.kt?0.00%?
    SessionsSettings.kt?70.45%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dZ0rxAUFcR.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 10, 2023

Size Report 1

Affected Products

  • firebase-sessions

    TypeBase (a53ab64)Merge (bc35cd2)Diff
    aar108 kB110 kB+2.21 kB (+2.0%)
    apk (aggressive)365 kB366 kB+304 B (+0.1%)
    apk (release)2.07 MB2.07 MB+968 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TZv1c7a3U9.html

@firebase firebase locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrothfeder jrothfeder jrothfeder approved these changes

Assignees

No one assigned

Labels

no-changelog size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrober @google-oss-bot @jrothfeder