Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage test dependency on appcheck #4854

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Fix storage test dependency on appcheck #4854

merged 2 commits into from
Apr 5, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 5, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 5, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-storage

    Overall coverage changed from ? (360d25f) to 85.82% (9c8df0e) by ?.

    46 individual files with coverage change

    FilenameBase (360d25f)Merge (9c8df0e)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?86.60%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?87.50%?
    StorageException.java?65.45%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.38%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?100.00%?
    StreamDownloadTask.java?88.89%?
    TaskListenerImpl.java?100.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.46%?
    Util.java?73.24%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Vya8dX5JJT.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 5, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (360d25f)Merge (9c8df0e)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-storage

    TypeBase (360d25f)Merge (9c8df0e)Diff
    aar?116 kB? (?)
    apk (aggressive)?359 kB? (?)
    apk (release)?1.59 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xPST5goMMm.html

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023 •
edited
Loading

Unit Test Results

  36 files    36 suites   6m 5s ⏱️
126 tests 126 ✔️ 0 💤 0 ❌
252 runs  252 ✔️ 0 💤 0 ❌

Results for commit ab1909b.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 5, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (9c8df0e) and the base commit (360d25f) are not available.

No macrobenchmark data found for the base commit (360d25f). Analysis for the CI merge commit (9c8df0e) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NiC9uzTxyP/index.html

@rlazo rlazo enabled auto-merge (squash) April 5, 2023 14:45
maneesht
maneesht approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@maneesht maneesht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlazo rlazo merged commit 62c7cec into master Apr 5, 2023
@rlazo rlazo deleted the rl.storage_fix_test branch April 5, 2023 16:30
@rlazo rlazo mentioned this pull request Apr 5, 2023
Merged
@firebase firebase locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maneesht maneesht maneesht approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @maneesht