Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Config HTTP errors for some RTL locales #3757

Closed
ilyasipek opened this issue May 28, 2022 · 17 comments
Closed

Remote Config HTTP errors for some RTL locales #3757

ilyasipek opened this issue May 28, 2022 · 17 comments
Assignees
Labels
api: remoteconfig type: bug Something isn't working

Comments

@ilyasipek
Copy link

ilyasipek commented May 28, 2022

Environment

  • Android Studio version: Android Studio Chipmunk | 2021.2.1 Patch 1
  • Firebase Component: Remote Config
  • Component version: firebase-bom:30.1.0

The problem

I have an application that supports multiple locals languages and remote configurations work fine with any LTR language (EN, FR, etc) but it gives me FirebaseRemoteConfigServerException in all the RTL languages (I have tried Arabic, Urdu and Persian)

Steps to reproduce:

Just setting the apps locale to any RTL language will give this error.
FirebaseRemoteConfigServerException: Fetch failed: The server returned an unexpected error.
400 bad request

Relevant Code:

private val remoteConfig by lazy {
       val settings = remoteConfigSettings {
           minimumFetchIntervalInSeconds = if (BuildConfig.DEBUG) {
               0
           } else {
               60 * 30
           }
       }
       val defaults = mutableMapOf<String, Any>(
           "a" to true,
           "b" to true
       )
       Firebase.remoteConfig.apply {
           setConfigSettingsAsync(settings)
           setDefaultsAsync(defaults)
       }
   }

   fun init() {
       loadSettings()
   }

   private fun loadSettings() {
       remoteConfig.fetchAndActivate()
           .addOnSuccessListener {
               Toast.makeText(context, "Done", Toast.LENGTH_SHORT).show()
           }.addOnFailureListener {
               Toast.makeText(context, "$it", Toast.LENGTH_SHORT).show()
           }
   }

and in my application

override fun onCreate() {
        super.onCreate()
        remoteConfigUtil.init()
        ...
    }
@google-oss-bot
Copy link
Contributor

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@argzdev
Copy link
Contributor

argzdev commented May 31, 2022

Thanks for reporting, @ilyasipek. I was able to reproduce the same behavior, I'll notify an engineer to see what we can do here.

@argzdev argzdev added the type: bug Something isn't working label May 31, 2022
@danasilver danasilver self-assigned this May 31, 2022
@danasilver
Copy link
Contributor

Thanks for reporting the issue @ilyasipek! Based on the error it looks like it might be a server-side issue. We're investigating now and will update this thread when we know more.

@ilyasipek
Copy link
Author

Thanks for replying @danasilver, any updates? My app is already in production with thousands of users!
İ need help please 🥺

@Ali1Ammar
Copy link

i have same error with my flutter app
i get this error if the phone language arabic
[firebase_remote_config/unknown] unknown remote config error

@joeblak
Copy link

joeblak commented Jul 4, 2022

I also got same error when I tried Arabic and Persian. The error message didn't help so I decided to intercept app traffic with a sniffer. I found the following.

RTL Request (Arabic)

curl --location --request POST 'https://firebaseremoteconfig.googleapis.com/v1/projects/1016876665405/namespaces/firebase:fetch' \ --header 'X-Goog-Api-Key: AIzaSyCTiu0LuHaRpfLgGcPH_SHfTPVLex1sIYI' \ --header 'X-Android-Package: com.remoteconfig_rtl_issue.test' \ --header 'X-Android-Cert: 91696BFEF38793522E44BC7414810D84B73324C0' \ --header 'X-Google-GFE-Can-Retry: yes' \ --header 'X-Goog-Firebase-Installations-Auth: eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJhcHBJZCI6IjE6MTAxNjg3NjY2NTQwNTphbmRyb2lkOjVlOWIxMDkyNTI2YzUyNmViMWI4NTQiLCJleHAiOjE2NTc1NzA5MzYsImZpZCI6ImRReGJEUWVxUW1HVHhuME9ZNmRXczYiLCJwcm9qZWN0TnVtYmVyIjoxMDE2ODc2NjY1NDA1fQ.AB2LPV8wRgIhAKmz58Z_8FVypbciuJvfHMWz6OrU781reW1KAd3jPnr0AiEAyLksaa3hBDNxumhAyUz08quUuV-AlJVdQiuhwyWLWgw' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'User-Agent: Dalvik/2.1.0 (Linux; U; Android 6.0.1; SM-G610F Build/MMB29K)' \ --header 'Connection: Keep-Alive' \ --data-raw '{ "platformVersion": "23", "appInstanceId": "dQxbDQeqQmGTxn0OY6dWs6", "packageName": "com.remoteconfig_rtl_issue.test", "appVersion": "1.0", "countryCode": "AE", "sdkVersion": "21.1.0", "appBuild": "1", "firstOpenTime": "٢٠٢٢-٠٧-٠٤T٢١:٠٠:٠٠.٠٠٠Z", "analyticsUserProperties": {}, "languageCode": "ar-AE", "appId": "1:1016876665405:android:5e9b1092526c526eb1b854", "appInstanceIdToken": "eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJhcHBJZCI6IjE6MTAxNjg3NjY2NTQwNTphbmRyb2lkOjVlOWIxMDkyNTI2YzUyNmViMWI4NTQiLCJleHAiOjE2NTc1NzA5MzYsImZpZCI6ImRReGJEUWVxUW1HVHhuME9ZNmRXczYiLCJwcm9qZWN0TnVtYmVyIjoxMDE2ODc2NjY1NDA1fQ.AB2LPV8wRgIhAKmz58Z_8FVypbciuJvfHMWz6OrU781reW1KAd3jPnr0AiEAyLksaa3hBDNxumhAyUz08quUuV-AlJVdQiuhwyWLWgw", "timeZone": "Africa\/Dar_es_Salaam" }'

The error message after above request:

{ "error": { "code": 400, "message": "Invalid value at 'first_open_time' (type.googleapis.com/google.protobuf.Timestamp), Field 'firstOpenTime', Invalid time format: Failed to parse input", "status": "INVALID_ARGUMENT", "details": [ { "@type": "type.googleapis.com/google.rpc.BadRequest", "fieldViolations": [ { "field": "first_open_time", "description": "Invalid value at 'first_open_time' (type.googleapis.com/google.protobuf.Timestamp), Field 'firstOpenTime', Invalid time format: Failed to parse input" } ] } ] } }

LTR Request (English)

curl --location --request POST 'https://firebaseremoteconfig.googleapis.com/v1/projects/1016876665405/namespaces/firebase:fetch' \ --header 'X-Goog-Api-Key: AIzaSyCTiu0LuHaRpfLgGcPH_SHfTPVLex1sIYI' \ --header 'X-Android-Package: com.remoteconfig_rtl_issue.test' \ --header 'X-Android-Cert: 91696BFEF38793522E44BC7414810D84B73324C0' \ --header 'X-Google-GFE-Can-Retry: yes' \ --header 'X-Goog-Firebase-Installations-Auth: eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJhcHBJZCI6IjE6MTAxNjg3NjY2NTQwNTphbmRyb2lkOjVlOWIxMDkyNTI2YzUyNmViMWI4NTQiLCJleHAiOjE2NTc1NzA5MzYsImZpZCI6ImRReGJEUWVxUW1HVHhuME9ZNmRXczYiLCJwcm9qZWN0TnVtYmVyIjoxMDE2ODc2NjY1NDA1fQ.AB2LPV8wRgIhAKmz58Z_8FVypbciuJvfHMWz6OrU781reW1KAd3jPnr0AiEAyLksaa3hBDNxumhAyUz08quUuV-AlJVdQiuhwyWLWgw' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'User-Agent: Dalvik/2.1.0 (Linux; U; Android 6.0.1; SM-G610F Build/MMB29K)' \ --header 'Connection: Keep-Alive' \ --data-raw '{ "platformVersion": "23", "appInstanceId": "dQxbDQeqQmGTxn0OY6dWs6", "packageName": "com.remoteconfig_rtl_issue.test", "appVersion": "1.0", "countryCode": "US", "sdkVersion": "21.1.0", "appBuild": "1", "firstOpenTime": "2022-07-04T21:00:00.000Z", "analyticsUserProperties": {}, "languageCode": "en-US", "appId": "1:1016876665405:android:5e9b1092526c526eb1b854", "appInstanceIdToken": "eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJhcHBJZCI6IjE6MTAxNjg3NjY2NTQwNTphbmRyb2lkOjVlOWIxMDkyNTI2YzUyNmViMWI4NTQiLCJleHAiOjE2NTc1NzA5MzYsImZpZCI6ImRReGJEUWVxUW1HVHhuME9ZNmRXczYiLCJwcm9qZWN0TnVtYmVyIjoxMDE2ODc2NjY1NDA1fQ.AB2LPV8wRgIhAKmz58Z_8FVypbciuJvfHMWz6OrU781reW1KAd3jPnr0AiEAyLksaa3hBDNxumhAyUz08quUuV-AlJVdQiuhwyWLWgw", "timeZone": "Africa\/Dar_es_Salaam" }'

The response was successful for LTR request.

I think the server cannot understand Arabic time. I hope this gets fixed soon.

You can access the above requests here https://www.getpostman.com/collections/e8c2d62e5f9efcff8354

@nabilsunesara
Copy link

I also got same error when I tried Arabic and Persian. The error message didn't help so I decided to intercept app traffic with a sniffer. I found the following.

RTL Request (Arabic)

curl --location --request POST 'https://firebaseremoteconfig.googleapis.com/v1/projects/1016876665405/namespaces/firebase:fetch' \ --header 'X-Goog-Api-Key: AIzaSyCTiu0LuHaRpfLgGcPH_SHfTPVLex1sIYI' \ --header 'X-Android-Package: com.remoteconfig_rtl_issue.test' \ --header 'X-Android-Cert: 91696BFEF38793522E44BC7414810D84B73324C0' \ --header 'X-Google-GFE-Can-Retry: yes' \ --header 'X-Goog-Firebase-Installations-Auth: eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJhcHBJZCI6IjE6MTAxNjg3NjY2NTQwNTphbmRyb2lkOjVlOWIxMDkyNTI2YzUyNmViMWI4NTQiLCJleHAiOjE2NTc1NzA5MzYsImZpZCI6ImRReGJEUWVxUW1HVHhuME9ZNmRXczYiLCJwcm9qZWN0TnVtYmVyIjoxMDE2ODc2NjY1NDA1fQ.AB2LPV8wRgIhAKmz58Z_8FVypbciuJvfHMWz6OrU781reW1KAd3jPnr0AiEAyLksaa3hBDNxumhAyUz08quUuV-AlJVdQiuhwyWLWgw' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'User-Agent: Dalvik/2.1.0 (Linux; U; Android 6.0.1; SM-G610F Build/MMB29K)' \ --header 'Connection: Keep-Alive' \ --data-raw '{ "platformVersion": "23", "appInstanceId": "dQxbDQeqQmGTxn0OY6dWs6", "packageName": "com.remoteconfig_rtl_issue.test", "appVersion": "1.0", "countryCode": "AE", "sdkVersion": "21.1.0", "appBuild": "1", "firstOpenTime": "٢٠٢٢-٠٧-٠٤T٢١:٠٠:٠٠.٠٠٠Z", "analyticsUserProperties": {}, "languageCode": "ar-AE", "appId": "1:1016876665405:android:5e9b1092526c526eb1b854", "appInstanceIdToken": "eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJhcHBJZCI6IjE6MTAxNjg3NjY2NTQwNTphbmRyb2lkOjVlOWIxMDkyNTI2YzUyNmViMWI4NTQiLCJleHAiOjE2NTc1NzA5MzYsImZpZCI6ImRReGJEUWVxUW1HVHhuME9ZNmRXczYiLCJwcm9qZWN0TnVtYmVyIjoxMDE2ODc2NjY1NDA1fQ.AB2LPV8wRgIhAKmz58Z_8FVypbciuJvfHMWz6OrU781reW1KAd3jPnr0AiEAyLksaa3hBDNxumhAyUz08quUuV-AlJVdQiuhwyWLWgw", "timeZone": "Africa\/Dar_es_Salaam" }'

The error message after above request:

{ "error": { "code": 400, "message": "Invalid value at 'first_open_time' (type.googleapis.com/google.protobuf.Timestamp), Field 'firstOpenTime', Invalid time format: Failed to parse input", "status": "INVALID_ARGUMENT", "details": [ { "@type": "type.googleapis.com/google.rpc.BadRequest", "fieldViolations": [ { "field": "first_open_time", "description": "Invalid value at 'first_open_time' (type.googleapis.com/google.protobuf.Timestamp), Field 'firstOpenTime', Invalid time format: Failed to parse input" } ] } ] } }

LTR Request (English)

curl --location --request POST 'https://firebaseremoteconfig.googleapis.com/v1/projects/1016876665405/namespaces/firebase:fetch' \ --header 'X-Goog-Api-Key: AIzaSyCTiu0LuHaRpfLgGcPH_SHfTPVLex1sIYI' \ --header 'X-Android-Package: com.remoteconfig_rtl_issue.test' \ --header 'X-Android-Cert: 91696BFEF38793522E44BC7414810D84B73324C0' \ --header 'X-Google-GFE-Can-Retry: yes' \ --header 'X-Goog-Firebase-Installations-Auth: eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJhcHBJZCI6IjE6MTAxNjg3NjY2NTQwNTphbmRyb2lkOjVlOWIxMDkyNTI2YzUyNmViMWI4NTQiLCJleHAiOjE2NTc1NzA5MzYsImZpZCI6ImRReGJEUWVxUW1HVHhuME9ZNmRXczYiLCJwcm9qZWN0TnVtYmVyIjoxMDE2ODc2NjY1NDA1fQ.AB2LPV8wRgIhAKmz58Z_8FVypbciuJvfHMWz6OrU781reW1KAd3jPnr0AiEAyLksaa3hBDNxumhAyUz08quUuV-AlJVdQiuhwyWLWgw' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'User-Agent: Dalvik/2.1.0 (Linux; U; Android 6.0.1; SM-G610F Build/MMB29K)' \ --header 'Connection: Keep-Alive' \ --data-raw '{ "platformVersion": "23", "appInstanceId": "dQxbDQeqQmGTxn0OY6dWs6", "packageName": "com.remoteconfig_rtl_issue.test", "appVersion": "1.0", "countryCode": "US", "sdkVersion": "21.1.0", "appBuild": "1", "firstOpenTime": "2022-07-04T21:00:00.000Z", "analyticsUserProperties": {}, "languageCode": "en-US", "appId": "1:1016876665405:android:5e9b1092526c526eb1b854", "appInstanceIdToken": "eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJhcHBJZCI6IjE6MTAxNjg3NjY2NTQwNTphbmRyb2lkOjVlOWIxMDkyNTI2YzUyNmViMWI4NTQiLCJleHAiOjE2NTc1NzA5MzYsImZpZCI6ImRReGJEUWVxUW1HVHhuME9ZNmRXczYiLCJwcm9qZWN0TnVtYmVyIjoxMDE2ODc2NjY1NDA1fQ.AB2LPV8wRgIhAKmz58Z_8FVypbciuJvfHMWz6OrU781reW1KAd3jPnr0AiEAyLksaa3hBDNxumhAyUz08quUuV-AlJVdQiuhwyWLWgw", "timeZone": "Africa\/Dar_es_Salaam" }'

The response was successful for LTR request.

I think the server cannot understand Arabic time. I hope this gets fixed soon.

You can access the above requests here https://www.getpostman.com/collections/e8c2d62e5f9efcff8354

Looks like the "firstOpenTime": "٢٠٢٢-٠٧-٠٤T٢١:٠٠:٠٠.٠٠٠Z" is sent in arabic. Could be an encoding/decoding issue?

@danasilver
Copy link
Contributor

Thanks for the reports and detailed debugging. That's an interesting observation about the firstOpenTime parameter. We're investigating now and will let you know what we find.

@danasilver
Copy link
Contributor

We've identified the issue and are working on a fix in the SDK.

@joeblak
Copy link

joeblak commented Jul 6, 2022

We've identified the issue and are working on a fix in the SDK.

Great, thanks. I hope soon.

richaurora added a commit that referenced this issue Jul 6, 2022
…. This makes sure that first-open time digits are not formatted to the local language characters.

This change is a fix for #3757
richaurora added a commit that referenced this issue Jul 6, 2022
…. This ensures that the english numerals in the timestamp are not converted to the local language numerals.

This is a fix for #3757
richaurora added a commit that referenced this issue Jul 7, 2022
#3877)

* Pass "Locale-US" to SimpleDateFormat while formatting first-open time. This ensures that the english numerals in the timestamp are not converted to the local language numerals.

This is a fix for #3757

* adding more detail to a comment
@danasilver
Copy link
Contributor

Thanks for your patience, everyone. We'll be releasing the new version of the SDK with the fix next week and in the meantime have marked v21.1.0 as deprecated. We recommend using the previous version of Remote Config (v21.0.2) in the meantime, which does not contain this bug.

I'll update this issue once that new version is live. Thanks!

@danasilver danasilver changed the title Android - Remote Config RTL language issue Remote Config HTTP errors for some RTL locales Jul 8, 2022
@JonasTrikiSPV
Copy link

The newly released com.google.firebase:firebase-bom:30.3.0 contains com.google.firebase:firebase-config:21.1.1 - is the bug fixed in this version? 😊

@danasilver
Copy link
Contributor

Yep! You beat me to it @JonasTrikiSPV! 😄 This is fixed in Remote Config v21.1.1 and Firebase BOM v30.3.0. Thanks everyone.

@zmeggyesi
Copy link

Does this upgrade need to be propagated manually to the Flutter/Dart packages? Or will it be pulled in automatically, without having to upgrade the Pub dependencies?

@costacoz
Copy link

costacoz commented Jul 19, 2022

Does this upgrade need to be propagated manually to the Flutter/Dart packages? Or will it be pulled in automatically, without having to upgrade the Pub dependencies?

@zmeggyesi
I've updated to the latest available firebase_remote_config package. But during the release I still get message: The developer of Firebase Remote Config (com.google.firebase:firebase-config) has reported critical issues with version 21.1.0
I'm also very curious whether the new version be present soon in flutter package.

@mono0926
Copy link

mono0926 commented Jul 20, 2022

I'm also very curious whether the new version be present soon in flutter package.

Latest firebase_core 1.19.2 depends on Android SDK v30.1.0: https://github.com/firebase/flutterfire/blob/796f1e744fa361a023aba4ec7f491387a9e2f0f8/packages/firebase_core/firebase_core/android/gradle.properties#L2
([Edit] updated to v30.3.0 now: https://github.com/firebase/flutterfire/blob/bf1d9be11a59475be173b01184efb53d92d152fe/packages/firebase_core/firebase_core/android/gradle.properties#L2)

The problem was fixed in v30.3.0, so it is needed to wait for the firebase_core release which depends on Android SDK v30.3.0, or use an older version that does not have this problem(I don't know which version applies), or fork it yourself.

Yep! You beat me to it @JonasTrikiSPV! 😄 This is fixed in Remote Config v21.1.1 and Firebase BOM v30.3.0. Thanks everyone.
#3757 (comment)

@zmeggyesi
Copy link

@mono0926 @costacoz Looks like the change itself is already in master there, they just need to hammer it through their release process. I opened an issue in the FlutterFire repo to nudge things along, hopefully.

@firebase firebase locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: remoteconfig type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests