fix release upload process #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Fisher <[email protected]>
zip is not installed on Windows runners... Instead we need to use 7z. https://github.com/TheDoctor0/zip-release/blob/master/entrypoint.sh recommends a path forward, but let's drop this for 0.1.0 and reintroduce afterwards. Signed-off-by: Matthew Fisher <[email protected]>
vdice
requested changes
Mar 30, 2022
Signed-off-by: Matthew Fisher <[email protected]>
|
Updated the title. This overhauls the release process and has been tested with hippo-cli:
In a separate job that relies on
This is because each runner maintains its own filesystem, so we have to upload all assets to github, then re-download them to generate the checksums in one fell swoop. |
bacongobbler
commented
Mar 30, 2022
vdice
approved these changes
Mar 30, 2022
radu-matei
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that v2.1.0 introduced multiple upload path support: https://github.com/actions/upload-artifact/releases/tag/2.1.0
Bumping to v3 should fix this.