-
Notifications
You must be signed in to change notification settings - Fork 0
Remove run-onboarding-managed-tokens executable and merge it into token-push
#111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…condor_vault_storer from executables using same func signature as other workers
…ker should be used with to run condor_vault_storer
… introduce worker.Worker type
…ng func instances
…sForWorkers interface
… only accept InteractiveTokenStorer or NonInteractiveTokenStorer
… meant to be used externally
well as new StoreAndGetTokensInteractiveWorker In discussion with stlammel about this code base, he brought up that it wasn't easy to find where exactly these workers loop over the schedds to store tokens. To make that much clearer, I moved the loops out of StoreAndGetTokenForSchedds, renamed that function to StoreAndGetTokenForSchedd, and made it only handle the operations for a single token store. The loop then moved into the two worker funcs mentioned above. This required some rewriting of the error handling as well, since in both cases, we need to check for and report the correct errors across different operations.
…anonymous func for better structure
…rt fileCopier interface
… PingNodeStatus to worker package, as package ping never uses this type. Finally, changed Node.PingNode to Node.Ping
…StoreAndGetTokenInteractiveWorkerType] map uninitialized
…hat back in and also added an info message for run-onboarding mode
…at means they are duplicated, but it removes a dependency
…nless there were valid service configs
…rate collector goroutine, each config setup goroutine simply accesses the serviceConfigs and successfulServices maps directly. Access is mediated through mutexes for both
…tifications chan was getting blocked due to absence of listener. I introduced this bug in commit 861bc7a
…erNotificationsChans to a new func registerDummyServiceNotificationsChan that gets invoked in the service Config setup stage
… drain the notifications channels
cathulhu
approved these changes
Dec 6, 2024
Contributor
cathulhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally finished looking over all of this. Consistent with what I know of GO and looks like a good approach. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72.
The changes are:
For more details on the changes and tests run, see #72 (comment)