Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improvements to existing rules #13

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Further improvements to existing rules #13

merged 4 commits into from
Jun 29, 2022

Conversation

feluelle
Copy link
Owner

@feluelle feluelle commented Jun 28, 2022 •
edited
Loading

  • allow variable reference for Variable.get
  • allow from-imports in UseFunctionLevelImports rule
  • allow all combinations of Variable.get calls
  • update docs

@feluelle
Further improvements to existing rules
c0709b1 
- allow variable reference for Variable.get
- allow from-imports in UseFunctionLevelImports rule
- allow all combinations of Variable.get calls
- remove import_finder
- refactoring
- update poetry deps
- update docs
@feluelle
Respect scopes in UseJinjaVariableGet
d2ec342 
- reorder test cases and add comments
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022 •
edited
Loading

Codecov Report

Merging #13 (d2ec342) into main (cff2063) will increase coverage by 4.21%.
The diff coverage is 98.03%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   88.88%   93.10%   +4.21%     
==========================================
  Files           6        5       -1     
  Lines          81      116      +35     
==========================================
+ Hits           72      108      +36     
+ Misses          9        8       -1
Impacted Files Coverage Δ
airflint/rules/use_function_level_imports.py 100.00% <ø> (ø)
airflint/rules/use_jinja_variable_get.py 98.33% <98.03%> (+9.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff2063...d2ec342. Read the comment docs.

@feluelle
Add test case for unsupported Variable.get parents types
4f15392 
- ignore coverage for airflint/__main__.py
@feluelle feluelle marked this pull request as ready for review June 29, 2022 08:49
@feluelle feluelle merged commit 5192030 into main Jun 29, 2022
@feluelle feluelle deleted the feature/rules-improvements branch June 29, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feluelle @codecov-commenter