Skip to content

fix bug 1105 #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ybouilla
Copy link
Contributor

PR description

Fixes bug 1105 of fedbiomed.

Solution proposed in the PR doesnot work because niftii files can be compressed (*.nii.gz), and it consider only the .gz. A better approach could be not relying on extension but using specific libraries ( through built-in imghdr for instance)

Developer Certificate Of Origin (DCO)

By opening this merge request, you agree to the
Developer Certificate of Origin (DCO)

This DCO essentially means that:

  • you offer the changes under the same license agreement as the project, and
  • you have the right to do that,
  • you did not steal somebody else’s work.

License

Project code files should begin with these comment lines to help trace their origin:

# This file is originally part of Fed-BioMed
# SPDX-License-Identifier: Apache-2.0

Code files can be reused from another project with a compatible non-contaminating license.
They shall retain the original license and copyright mentions.
The CREDIT.md file and credit/ directory shall be completed and updated accordingly.

Guidelines for PR review

General:

Specific to some cases:

  • update all conda envs consistently (development and vpn, Linux and MacOS)
  • if modified researcher (eg new attributes in classes) check if breakpoint needs update (breakpoint/load_breakpoint in Experiment(), save_state_breakpoint/load_state_breakpoint in aggregators, strategies, secagg, etc.)
  • if modified a component with versioning (config files, breakpoint, messaging protocol) then update the version following the rules in common/utils/_versions.py

ybouilla and others added 5 commits September 4, 2024 10:00
- includes a shanoir dataset
- poc has been made in a  notebook
- clarifies exception while loading a medical folder dataset in fedbiomed
- considers the date specified in the `import-job.json` instead of the date
in the folder name
@ybouilla ybouilla closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant