-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆ Upgrade Rich, support 13.x #524
Conversation
Based on the changelog, the only relevant breaking change is that support for Python 3.6 is removed: https://github.com/Textualize/rich/blob/v13.0.0/CHANGELOG.md#1300---2022-12-30 This is OK even though we support Python 3.6 in typer, because we do still allow older versions of rich that are compatible with Python 3.6.
📝 Docs preview for commit 5bf232e at: https://63b442aa8de82e7d7a3da3e9--typertiangolo.netlify.app |
I am very much looking forward to this change as currently there is no easy way to use the latest versions of
|
Can any actions help offload the review responsibilities from tialango or other maintainers? I understand he's busy across multiple projects and his day job, but happy to help if there is a way to get this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Tests pass for each Python version with 3.6 installing Rich 12.6, and 3.7+ installing 13+.
I'm not a maintainer, but I hope this review helps with getting this merged by one.
100% support this (and generally not capping dependencies, even more so for a less-actively maintained project; see a lot of great arguments in https://iscinumpy.dev/post/bound-version-constraints/). That being said, - typer[all]
+ typer
+ colorama >=0.4.3,<0.5.0
+ shellingham >=1.3.0,<2.0.0
+ rich >=10.11.0,<14.0.0 Not perfect, but it gets the job done for a consuming library blocked by this. |
@musicinmybrain Can you merge this ? |
I’m afraid not. I’m not a maintainer of this project, and I have no permissions on the repository. |
My bad, I falsely assumed your PR was reviewed by maintainers. |
Thanks @musicinmybrain! 🚀 And thanks @atmartinez for you review with a comment explaining what you did to test it, that helps a lot! 🙇 This will be available in Typer |
Based on the changelog, the only relevant breaking change is that support for Python 3.6 is removed:
https://github.com/Textualize/rich/blob/v13.0.0/CHANGELOG.md#1300---2022-12-30
This is OK even though we support Python 3.6 in typer, because we do still allow older versions of rich that are compatible with Python 3.6.