Fix setlocale() with magic locale strings #8834
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two write-only magic locale C strings for
setlocale
""
, which means "set the locale based on the environment""0"
), which means"return the current locale"
On a fresh request,
setlocale(LC_ALL, "0")
previously returned""
,but
"C"
, not inherited from the environment (this matchesC and Python, but PHP inherits from the environment by default)
""
should never be returned as a localeAdditionally, setting to
""
did set the locale to be inherited from theenvironment, but calling
setlocale(LC_ALL, "")
would return the empty string(indistinguishable from the initial state) rather than the locale.
This diff does not change the default locale or how setting works, but it does
correct the indicated locale, which was previously incorrect in these cases.
Future work will probably include
it without changing the state
Test Plan:
debugger
For multiple requests
and in another terminal...