[go][iOS] Handle initialUrl passed in the argv
#33182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
approved these changes
Nov 22, 2024
Kudo
approved these changes
Nov 22, 2024
brentvatne
approved these changes
Nov 22, 2024
lukmccall
added a commit
that referenced
this pull request
Nov 26, 2024
# Why Handles the `initialUrl` argument when passed as a process argument. In the Radeon IDE, the application is currently opened via a deep link, which presents a significant drawback: there is no way to access the process's stdout. The IDE team would like to launch the application using `xcrun simctl launch` to access process logs and capture native errors. This pull request adds support for an `initialUrl` parameter passed in the `argv`. # How Parsed the `argv` when calculating the `initialUrl`. # Test Plan - launch app from icon ✅ - launch app using `xcrun simctl launch` ✅ ``` xcrun simctl launch <device_id> host.exp.Exponent --initialUrl "exp://192.168.0.235:8081" ``` - launch app using deep link ✅ ``` xcrun simctl openurl booted exp://192.168.0.235:8081 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Handles the
initialUrlargument when passed as a process argument.In the Radeon IDE, the application is currently opened via a deep link, which presents a significant drawback: there is no way to access the process's stdout. The IDE team would like to launch the application using
xcrun simctl launchto access process logs and capture native errors. This pull request adds support for aninitialUrlparameter passed in theargv.How
Parsed the
argvwhen calculating theinitialUrl.Test Plan
xcrun simctl launch✅