[ios][camera] Remove warning #32948
Merged
[ios][camera] Remove warning #32948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
|
The Pull Request introduced fingerprint changes against the base commit: 4cb6f58 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-camera/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "a2cb3554d6a851a1e974902e4b3e19cc7bd2889e"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-camera/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "d006994df2c8a986f066bf94a5ca1570750ff7d3"
}
}
]Generated by PR labeler 🤖 |
|
Subscribed to pull request
Generated by CodeMention |
lukmccall
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Theres a warning in the cameraView because of how we use the compiler directive.
How
Made it if/else to remove the warning
Test Plan
n/a