[cli]: improve simulator labels when printing usage verbosely #30403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
|
Subscribed to pull request
Generated by CodeMention |
vonovak
requested changes
Nov 22, 2024
vonovak
changed the title
vonovak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It’s easy to mix up which emulator/simulator to open, especially if you don’t know that ‘a’ is for Android (shift + a) and ‘i’ is for iOS (shift + i). So, it’s better to clarify this in the instructions
How
I just changed the command texts in cli/src/start/interface/commandsTable.ts
Test Plan
I just ran an npx expo start and then pressed "?", and all the commands appeared. The changes made will appear in the menu
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).