Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat configure headers and footers #863

Merged
merged 7 commits into from
Jun 24, 2019
Merged

Conversation

autukill
Copy link
Contributor

Add new features to configure headers and footers.
Not support add image to headers and footers.
Maybe readme.md needs you to re-edit, my English is not good.

@alubbe
Copy link
Member

alubbe commented Jun 16, 2019

Thanks for your PR! Could you please add some tests for this new feature?

@autukill
Copy link
Contributor Author

Yes, I am working on it.

@autukill
Copy link
Contributor Author

Thanks for your PR! Could you please add some tests for this new feature?

tests has been added

@guyonroche guyonroche merged commit a14df84 into exceljs:master Jun 24, 2019
@joyacv2
Copy link

joyacv2 commented Aug 23, 2019

Hi Autukill, Guyon!!!!

Thank you very much to both!!!!!!! Excellent!!!!!

I create this one:
#931

and I see that this one maybe is related. I want to know if you have an expected date to release the image feature for header and footer. Thank you very much!!!!!!!!!

@autukill
Copy link
Contributor Author

Hi Autukill, Guyon!!!!

Thank you very much to both!!!!!!! Excellent!!!!!

I create this one:
#931

and I see that this one maybe is related. I want to know if you have an expected date to release the image feature for header and footer. Thank you very much!!!!!!!!!

No plan, maybe you can add this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants