Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(README): improve docs #817

Closed
wants to merge 1 commit into from
Closed

docs(README): improve docs #817

wants to merge 1 commit into from

Conversation

zypA13510
Copy link
Contributor

@zypA13510 zypA13510 commented May 16, 2019 •
edited
Loading

  • Added documentation of writeBuffer() method.
  • Moved CSV read code block to the corresponding section.
  • Remove the duplicated CSV read code.

@zypA13510
docs(README): improve docs
d3cbcf6 
- Added documentation of `writeBuffer()` method.
- Moved CSV read code block to the corresponding section.
@zypA13510
Copy link
Contributor Author

@guyonroche The duplicated read CSV code actually exists since 2015, could you confirm which version (because it's different) of "read from a file with European Date-Times" and "read from a file with custom value formatting" do you want to keep?

guyonroche
guyonroche requested changes May 17, 2019
View reviewed changes
Copy link
Collaborator

@guyonroche guyonroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zypA13510 yeah - probably a result of copy-paste documentation...

Thanks for adding the writeBuffer() examples.

I think though - the example following the comment "read from a file with custom value formatting" is supposed to be "write to a file..." as mapping values is also a feature of csv.write

@guyonroche
Copy link
Collaborator

Merged (as part of b567395)

@guyonroche guyonroche closed this May 20, 2019
@zypA13510 zypA13510 deleted the patch-1 branch June 6, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyonroche guyonroche guyonroche requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zypA13510 @guyonroche