Skip to content

Conversation

@FreakenK
Copy link
Contributor

No description provided.

@alubbe alubbe requested review from Siemienik and guyonroche May 3, 2019 04:53
@alubbe
Copy link
Member

alubbe commented May 3, 2019

PR and tests look good, but I have never used this feature of exceljs (or excel). Can someone review it who is more closely aware of how this is used?

Copy link
Collaborator

@guyonroche guyonroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - will merge when I can

@guyonroche guyonroche merged commit a7bb3aa into exceljs:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants