Add the ability to bail out of parsing if the number of columns exceeds a given limit #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siemienik
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #541
Today we ran into a weird excel spreadsheet with 10803 columns (due to some weird accidentally applied formatting), which caused our import processing code to run out of memory despite using a
rowLimit🙄Implementing a column limit was pretty straightforward and analogous, so I went ahead and did that.
On the other hand, it would also be nice to implement some kind of overall "total cell limit" instead (or in addition), as it's the number of cells that determine the overall resource consumption. It seems like that would require passing around a shared object with counters. What do you think?