Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Worksheet.state typescript definition fix #714 #736

Merged
merged 4 commits into from
Feb 19, 2019

Conversation

ilyes-kechidi
Copy link
Contributor

No description provided.

index.d.ts Outdated Show resolved Hide resolved
@alubbe
Copy link
Member

alubbe commented Feb 11, 2019

I checked that the default value of the work sheet state is show, but from my understanding the same holds true for the options object when adding worksheets since it's just passed down to the constructor (in this PR, it's default value is visible). In that case, we should define this enum once and the re-use it in both type definitions. what do you think @Siemienik @guyonroche ?

@Siemienik
Copy link
Member

@alubbe fully agree,

as far as i know, 'show' is invalid value, it should be 'visible'
#621

@Siemienik Siemienik self-requested a review February 19, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants