Skip to content

Read worksheet hidden state #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Siemienik merged 3 commits into from
Feb 18, 2019
Merged

Read worksheet hidden state #728

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12206af
Fix bug: worksheet.state is always 'visible'
LesterLyu Jan 18, 2019
8829f43
add test xlsx, change test case title
LesterLyu Jan 18, 2019
eb8814d
Merge branch 'master' into fix-worksheet-state
LesterLyu Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test xlsx, change test case title
  • Loading branch information
@LesterLyu
LesterLyu committed Jan 18, 2019
commit 8829f4375d8a62d1ff2912db1565c8a9131e04f4
Binary file added spec/integration/data/test-pr-728.xlsx
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion spec/integration/pr/test-pr-728.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ var Excel = verquire('excel');
var expect = chai.expect;

describe('github issues', function() {
it('issue 73 and 226 - Read worksheet hidden state', function() {
it('pull request 728 - Read worksheet hidden state', function() {
var wb = new Excel.Workbook();
return wb.xlsx.readFile('./spec/integration/data/test-pr-728.xlsx')
.then(function() {
Expand Down