Replaced node-unzip-2 to unzipper package which is more robust #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be awesome to see this land. Before this change, we've seen a lot of errors and OOM crashes in production when using the streaming WorkbookReader. @guyonroche Please let us know if you need any additional info or code to get this merged |
|
@guyonroche any chance that you can take a look at this over the holidays? We have a fork of your repo using node-unzipper and it's working great - but we'd love to return to your npm published package |
johnmalkovich100
force-pushed
the
replace-unzip-lib
branch
from
f0f33e2 to
4f73dea
Compare
Siemienik
approved these changes
Jan 10, 2019
alubbe
approved these changes
Jan 11, 2019
|
unzipper package has no support for *.xls files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are actively using
exceljsin our company and noticed that sometimes we have a situation when CPU usage and memory consumption are very high if the source stream is broken or dead.After some investigation I noticed that
node-unzip-2lib is the reason of this behaviour. Unfortunately it's not well supported and we didn't find the root cause of this problem.We've found the
unzipperlib is a well supported fork of thenode-unziplib and it's pretty robust.In this PR,
node-unzip-2is replaced to theunzipperlib.Thanks a lot for the cool exceljs lib! 🤝