Fix misinterpreted ranges from <definedName> #636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I ran into a file that contained a bunch of formulas and external references in
<definedName>
s, which caused this crash:Turns out it's caused by what looks like a rather naive range extraction algorithm that doesn't take into account that the defined names could contain double quoted strings or formulas.
I'm unable to share the original file in its full glory, but I made a new one that reproduces one variant of the error.
I'm really not sure that this is the right fix -- it would probably be better to implement proper tokenization/parsing in
extractRanges
so that the full syntax is understood. Then again, that would be a lot of work, and to be honest I'm have no idea if those ranges are even used for anything important during the parsing?