Skip to content

Fix some xlsx stream read xlsx not in guaranteed order problem #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guyonroche merged 3 commits into from
Nov 7, 2018
Merged

Fix some xlsx stream read xlsx not in guaranteed order problem #578

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b8ace1
Fix some xlsx stream read get sharedstring index problem
May 30, 2018
7f18928
read xml in guaranteed order
May 30, 2018
286836b
fix
May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix
  • Loading branch information
methodchen committed May 30, 2018
commit 286836b209b12e0b253a87d8831a9d736a8333b3
2 changes: 1 addition & 1 deletion lib/stream/xlsx/workbook-reader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ utils.inherits(WorkbookReader, events.EventEmitter, {

self.emit('end');
self.atEnd = true;
if (!this.readers) {
if (!self.readers) {
self.emit('finished');
}
} else {
Expand Down