Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update moment to 2.19.3 #452 #453

Merged
merged 2 commits into from
Dec 6, 2017
Merged

update moment to 2.19.3 #452 #453

merged 2 commits into from
Dec 6, 2017

Conversation

cooltoast
Copy link
Contributor

@cooltoast cooltoast commented Dec 4, 2017 •
edited
Loading

Fixes #452. Also added a .travis.yml file for continuous integration.

all tests passing: https://travis-ci.org/cooltoast/exceljs

@cooltoast
Copy link
Contributor Author

@guyonroche does this look good to you? I'd like to merge this fix and update my exceljs to solve that vulnerability issue

@guyonroche
Copy link
Collaborator

@cooltoast thanks for this, I'll merge it and publish now

@guyonroche guyonroche merged commit 85ee13d into exceljs:master Dec 6, 2017
@cooltoast
Copy link
Contributor Author

@guyonroche thanks!

Please consider activating this repo in TravisCI: https://docs.travis-ci.com/user/getting-started/
It should immediately build and run the tests I've put in the .travis.yml file.

@cooltoast cooltoast mentioned this pull request Feb 6, 2018
Merged
@karabaesh karabaesh mentioned this pull request Nov 27, 2023
Open
@DhavalW DhavalW mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cooltoast @guyonroche