Skip to content

Issue 296 #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guyonroche merged 3 commits into from
Jun 22, 2017
Merged

Issue 296 #343

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88de8ae
Let new lines through xmlEncode function. See github issue 296 (https…
holly-weisser Jun 21, 2017
1141257
Removed version change. Added test.
holly-weisser Jun 22, 2017
92040af
Remove .only from test.
holly-weisser Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed version change. Added test.
  • Loading branch information
@holly-weisser
holly-weisser committed Jun 22, 2017
commit 1141257e66966a85fe369194c86a4851093644b4
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "exceljs",
"version": "0.4.13",
"version": "0.4.12",
"description": "Excel Workbook Manager - Read and Write xlsx and csv Files.",
"private": false,
"license": "MIT",
Expand Down
4 changes: 3 additions & 1 deletion spec/unit/utils/utils.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var expect = require('chai').expect;
var utils = require('../../../lib/utils/utils');

describe('utils', function() {
describe('xmlEncode', function() {
describe.only('xmlEncode', function() {
it('encodes xml text', function() {
expect(utils.xmlEncode('<')).to.equal('&lt;');
expect(utils.xmlEncode('>')).to.equal('&gt;');
Expand All @@ -17,6 +17,8 @@ describe('utils', function() {
.to.equal('abc abc');

expect(utils.xmlEncode('<a href="www.whatever.com">Talk to the H&</a>')).to.equal('&lt;a href=&quot;www.whatever.com&quot;&gt;Talk to the H&amp;&lt;/a&gt;');

expect(utils.xmlEncode('new\x0aline')).to.equal('new\x0aline');
});
});
describe('isDateFmt', function() {
Expand Down