Skip to content

do not skip empty string in shared strings so that indexes match #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guyonroche merged 1 commit into from
Dec 2, 2016
Merged

do not skip empty string in shared strings so that indexes match #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
do not skip empty string in shared strings so that indexes match
  • Loading branch information
Tomas Pokorny committed Nov 28, 2016
commit 388ec40fab8f56cd1851a2493c0f4dc21f2fe2b2
2 changes: 1 addition & 1 deletion lib/xlsx/xform/strings/shared-string-xform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ utils.inherits(SharedStringXform, BaseXform, {
model.richText.forEach(function(text) {
r.render(xmlStream, text);
});
} else if (model) {
} else if (model !== undefined && model !== null) {
this.map.t.render(xmlStream, model);
}
xmlStream.closeNode();
Expand Down