Skip to content

1842: New xlsx option for ignoring certain nodes for improved performance #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Siemienik merged 8 commits into from
Sep 21, 2023
Merged

1842: New xlsx option for ignoring certain nodes for improved performance #2132

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0d10573
1842: New xlsx option for ignoring certain nodes for improved perform…
hofnarwillie Sep 9, 2022
6f44152
Included test file
hofnarwillie Sep 9, 2022
e973737
Added typescript typings
Sep 12, 2022
886857f
Merge branch 'master' into master
Siemienik Apr 25, 2023
0e2170b
optimizing ifs
Siemienik Sep 21, 2023
5cd82db
new line EOF
Siemienik Sep 21, 2023
f88df56
Update README.md - available options
Siemienik Sep 21, 2023
050c418
Merge branch 'master' into master
Siemienik Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
optimizing ifs
  • Loading branch information
@Siemienik
Siemienik authored Sep 21, 2023
commit 0e2170bf79d660c042e74c8e7fc35af5668bee8c
6 changes: 2 additions & 4 deletions lib/xlsx/xform/sheet/worksheet-xform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,11 +369,9 @@ class WorkSheetXform extends BaseXform {
return true;
}

if (!this.ignoreNodes.includes(node.name)) {
if (this.map[node.name] && !this.ignoreNodes.includes(node.name)) {
this.parser = this.map[node.name];
if (this.parser) {
this.parser.parseOpen(node);
}
this.parser.parseOpen(node);
}
return true;
}
Expand Down