Run linter with prettier 2 #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alubbe
requested review from
guyonroche,
Alanscut and
Siemienik
and removed request for
guyonroche
Siemienik
requested changes
Sep 28, 2020
|
Agreed - I've reset the arrow-parens behaviour back to prettier v1 ('as-needed'). The other changes were always 'wrong', I think and they looks safe enough to merge |
Siemienik
requested changes
Sep 28, 2020
Siemienik
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
After some investigation, I changed max-len option to 100. Before was 160 - that value is too much for properly priettier 2 working.
As effect some improvements was introduced like:
https://github.com/exceljs/exceljs/pull/1477/files#diff-a083b92106d7d843e5f325cb350dbf25L102-R109
|
Looks good, I also found another typo - fixed, will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some files haven't had the linter applied to, so let's fix that :)
Test plan
No new tests are needed