Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix]Fix Issue #1254 and update index.d.ts #1360

Merged
merged 4 commits into from
Sep 28, 2020
Merged

[bugfix]Fix Issue #1254 and update index.d.ts #1360

merged 4 commits into from
Sep 28, 2020

Conversation

Alanscut
Copy link
Member

@Alanscut Alanscut commented Jun 30, 2020 •
edited
Loading

@Alanscut Alanscut requested a review from Siemienik June 30, 2020 03:32
Siemienik
Siemienik requested changes Jun 30, 2020
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using any is anty pattern, it means that we haven't control here,

More information I typed here: #1254 (comment)

@Alanscut Alanscut requested a review from Siemienik July 1, 2020 01:52
@Siemienik
Copy link
Member

Is it also possible to return always any array? [] instead of null or undefined

@alubbe alubbe merged commit 4b9b882 into exceljs:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alanscut @Siemienik @alubbe