Skip to content

Conversation

@Alanscut
Copy link
Member

Changes

  1. The purpose of this PR is to support inserting pictures with hyperlinks.
  2. fix for Is there any way to embed an image with hyperlink #899.

Please let me know if anything is needed for this PR.

@guyonroche
Copy link
Collaborator

@Alanscut Wow! Great work here. Can I ask you for two more changes?

  1. Add/amend the README.md file showing how to add images with hyperlinks
  2. Add an integration test that creates a new workbook containing an image with hyperlink and confirming that when the file is read back, it is as expected. spec/integration/workbook/images.spec.js has examples of how this is done

@Alanscut
Copy link
Member Author

@guyonroche Thanks your review! Have added the testcase and update README file as you instructed.

@guyonroche guyonroche merged commit 7721e0b into exceljs:master Jan 22, 2020
@Alanscut Alanscut deleted the issue_899 branch May 5, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants