Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unlocked cells do not maintain their unlocked status after reading and writing a workbook. #1205

Closed
Punknium opened this issue Apr 7, 2020 · 1 comment

Comments

@Punknium
Copy link

Punknium commented Apr 7, 2020

🐛 Bug Report

If I read in an xlsx file and then write it back out any unlocked cell will become locked.

Lib version: 3.8.2

Steps To Reproduce

Read and write an xlsx file.

Here is a before and after example, See E4 in the before and after.
ExcelJS-FormattingLockedCellAndDatavalidation.xlsx
ExcelJS-AFTER-FormattingLockedCellAndDatavalidation.xlsx

async load() {
  try {
    const wb = new ExcelJS.Workbook()
    await wb.xlsx.load(await this.file.arrayBuffer())
    const out = await wb.xlsx.writeBuffer()
    this.download(out)
  } catch (e) {
    console.error(e)
  }
}

The expected behaviour:

Unlocked cells stay unlocked after reading and writing a file.

@Alanscut
Copy link
Member

Alanscut commented Apr 9, 2020

See PR #1210 .

Siemienik added a commit that referenced this issue Apr 18, 2020
fix issue #1206 #1205 Abnormality of  and attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants