-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add i18n support and translation for zh-CN #394
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @evroon on Vercel. @evroon first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might also be that Next is trying to build the site with server-side rendering, you could try adding these lines from the docs: https://react.i18next.com/latest/ssr#setting-the-i18next-instance-based-on-req |
The error is quite straightforward, which I encountered during development but didn't give it enough attention. The error was caused by the incorrect placement of the useTranslation hook; it should not be used outside of a functional component. Additionally, some pages did not render the translation correctly, so I've implemented some fixes for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Translations look good to me overall, I have only small comments.
Could you also cherry-pick these commits onto this branch?
c49a99d
4201d52
The first one fixes yarn build
which fails now because this placeholder
parameter isn't allowed anymore apparently. The second just fixes formatting. After that, CI will pass.
Co-authored-by: Erik Vroon <[email protected]>
Co-authored-by: Erik Vroon <[email protected]>
Looks like the login page is broken, I will fix this tomorrow. |
@Sevichecc there is this error now: do you want to fix it or shall I finish this PR? |
@evroon I have committed a fix for that error, maybe I should try to build locally before committing. |
Thanks a lot again, let's merge this |
Relative issue: #223