refactor/setup-workspaces #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It detects the packageManager running the command to install the dependencies.
It adds the following dependencies: `@asyncapi/parser` and `prismjs`
🦋 Changeset detectedLatest commit: 3e98d3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It updates the Dockerfile to run with pnpm to ensure compatibility
carlosallexandre
force-pushed
the
refactor/setup-workspaces
branch
from
faf7b09 to
ca321c5
Compare
Updated the dependency check logic to verify the presence of the `node_modules` directory instead of relying solely on `require.resolve` for `astro`. This ensures more robust detection of installed dependencies.
|
Thank you @carlosallexandre let's give it ago! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #575
Changes Introduced
cliandastro.astrodeps on the user's directory. This hoist the deps to.eventcatalog-core/making them fully compatible withpnpm.clicommand and them if doesn't havenode_modules/inside the.eventcatalog-core/install all deps need by the astro.test-bin.ymlworkflow to run withpnpmpnpm.With that PR in place we can switch to
pnpm(#884)