Draft EIP: BLS12-381 Key Generation #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChico
reviewed
Oct 31, 2019
MrChico
reviewed
Oct 31, 2019
MrChico
reviewed
Oct 31, 2019
MrChico
reviewed
Oct 31, 2019
MrChico
reviewed
Oct 31, 2019
MrChico
reviewed
Oct 31, 2019
CarlBeek
commented
Oct 31, 2019
axic
reviewed
Oct 31, 2019
axic
approved these changes
Nov 7, 2019
|
@CarlBeek is it OK to merge or do you expect any changes soon? |
|
@CarlBeek ping |
Adds discussions-to Fix typos Remove "www" Apply @MrChico's suggestions from code review Co-Authored-By: MrChico <[email protected]> Switch to EIP numbering Tree idx < 2**320 Requires seed >= 128 bits Actually switch to salt to uint32 Drop TS/JS implementation
|
I have squashed the commits, so everything is ready to be merged here. |
|
Thanks! No need to squash though, because we merge with squash merges anyway 😉 |
CarlBeek
added a commit
to CarlBeek/EIPs
that referenced
this pull request
Nov 26, 2019
…tore * 'bls_keystore' of github.com:CarlBeek/EIPs: (47 commits) fix link to heading Fix spelling Fix email address Draft EIP: BLS12-381 Deterministic Account Hierarchy (ethereum#2334) Fix some URLs and require 2333 too Add name to metadata title (ethereum#2370) Draft: BLS12-381 Key Generation (ethereum#2333) Automatically merged updates to draft EIP(s) (ethereum#2397) Hard fork proposal to address the Ice age (ethereum#2387) Automatically merged updates to draft EIP(s) 1767 (ethereum#2262) EIP-2021: Payoutable Token (ethereum#2021) EIP-2009: Compliance Service (ethereum#2009) EIP-2019: Fundable Token (ethereum#2019) Use solidity/javascript highlighting in various EIPs (ethereum#2372) EIP-2018: Clearable Token (ethereum#2018) EIP-1996: Holdable token (ethereum#1996) Fix the username of @pizza-r0b in EIP-2309 (ethereum#2389) Clarify that empty accounts also return 0 in EIP-1052 (ethereum#2388) dType Functions Extension - Decentralized Type System for EVM (ethereum#2267) Fix spelling of GitHub [R4R] (ethereum#2369) ...
This was referenced Jun 2, 2020
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
Apply @MrChico's suggestions from code review Co-Authored-By: MrChico <[email protected]>
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
Apply @MrChico's suggestions from code review Co-Authored-By: MrChico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposed standard for BLS12-381 Key Generation for use within Eth2 as well as by the larger blockchain industry. It has existed in its own repo for a while now, but this is a better place to enshrine it as a standard for now.