Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorship in editor displayed incorrectly (as "false") after update #5401

Closed
dcht00 opened this issue Feb 3, 2022 · 4 comments
Closed

Authorship in editor displayed incorrectly (as "false") after update #5401

dcht00 opened this issue Feb 3, 2022 · 4 comments
Labels
wontfix Wont Fix these things, no hate.

Comments

@dcht00
Copy link
Collaborator

dcht00 commented Feb 3, 2022

Checking json from server, it's already coming in as "false".

2 separate instances exhibit same behaviour:

  • editor shows author name as "false" & color as blank
  • changing name&color works, but upon refresh, it's again same as above

(However concurrent users see others' name&colors fine, and it persists fine too).

In logs, when opening editor:
[WARN] message - Dropped message, USERINFO_UPDATE Color is malformed.[object Object]

I can provide a public instance example if needed.

Etherpad version is 1.9.0 (5d3c34a)
npm: 6.14.16
Node: v12.22.10
Plugins: None
Clients: latest Firefox @ Ubuntu
@dcht00
Copy link
Collaborator Author

dcht00 commented Feb 14, 2022

Update:

  • I upgraded node+npm on system
    npm: 8.5.0
    node: v14.19.0
  • recloned one of the etherpad instances on master branch.
    Etherpad version is 1.8.16 (142a47c)

That one now works fine, while the ones on 5d3c34a (develop branch) don't (might be connected to sessions, not version, though).

@g4rf
Copy link

g4rf commented Mar 22, 2022

It's the same with our public instance though it shows true. The error log says:

[2022-03-22 14:34:49.559] [ERROR] socket.io - Error handling pad message from ****: Error: COLLABROOM: USERINFO_UPDATE: malformed color: true
    at Object.exports.handleMessage (/home/etherpad/etherpad-lite/src/node/handler/PadMessageHandler.js:363:11)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async /home/etherpad/etherpad-lite/src/node/handler/SocketIORouter.js:76:14

Checking out version 1.8.16 142a47c get it working again:

git checkout 142a47c

@squiddle
Copy link

squiddle commented Apr 17, 2022 •
edited
Loading

Check your padOptions in the settings.json/credentials.json

Maybe you have userName and userColor set to false. whereas the default padOptions in Settings.js indicate it should be null.

i had the same mistake and the settings.template was fixed in 8c857a8

apparently the buggy handling of the previous false value mentioned in that commit, is now fixed on develop

@stale
Copy link

stale bot commented Jun 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Wont Fix these things, no hate. label Jun 18, 2022
@stale stale bot closed this as completed Jun 27, 2022
@duckinator duckinator mentioned this issue Jul 1, 2023
Closed
wmfgerrit pushed a commit to wikimedia/operations-puppet that referenced this issue Mar 4, 2024
[etherpad] Set userName and userColor padOptions to null
774785d 
Referenced here: ether/etherpad-lite#5401

This appears to be causing issues for some users.

Bug: T316421
Change-Id: I1b4b0c37018e841c6cab879c4bc9d0dbec188374
@dcht00 dcht00 mentioned this issue May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix Wont Fix these things, no hate.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@squiddle @dcht00 @g4rf