Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repokitteh sha to bring in improved ownerscheck #9295

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Update repokitteh sha to bring in improved ownerscheck #9295

merged 2 commits into from
Dec 16, 2019

Conversation

itayd
Copy link
Contributor

@itayd itayd commented Dec 10, 2019

Description:
Brings in repokitteh/modules#22.
Also pins modules in a more easier to read way globally for the modules repository.

Risk Level:
None for production.

Testing:
In a separate PR (#9294 -> repokitteh/modules@4ee2ed0).

Docs Changes:
TBD

Release Notes:
N/A

@itayd
Copy link
Contributor Author

itayd commented Dec 10, 2019

/rk-bless

@repokitteh-read-only
Copy link

This PR has been blessed, meaning its repokitteh changes are in effect in this PR.

😽

Caused by: #9295 was labeled by repokitteh[bot].

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Dec 10, 2019

/rk-unbless

@itayd
Copy link
Contributor Author

itayd commented Dec 10, 2019

/assign @htuch

Signed-off-by: Itay Donanhirsh <[email protected]>
@itayd
Copy link
Contributor Author

itayd commented Dec 10, 2019

/rk-bless

@repokitteh-read-only
Copy link

This PR has been blessed, meaning its repokitteh changes are in effect in this PR.

😽

Caused by: #9295 was labeled by repokitteh[bot].

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Dec 10, 2019

/rk-ping
/rk-unless

@repokitteh-read-only
Copy link

pong

😽

Caused by: a #9295 (comment) was created by @itayd.

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Dec 10, 2019

/rk-unbless

@htuch
Copy link
Member

htuch commented Dec 10, 2019

@itayd LGTM; you mentioned on IM that you want to chat before merging, otherwise good to go.

Signed-off-by: Itay Donanhirsh <[email protected]>
@itayd
Copy link
Contributor Author

itayd commented Dec 16, 2019

@htuch ok to merge

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, can't wait to try this out!

@htuch htuch merged commit 46fc47b into envoyproxy:master Dec 16, 2019
prakhag1 pushed a commit to prakhag1/envoy that referenced this pull request Jan 3, 2020
Brings in repokitteh/modules#22.
Also pins modules in a more easier to read way globally for the modules repository.

Risk Level:
None for production.

Testing:
In a separate PR (envoyproxy#9294 -> repokitteh/modules@4ee2ed0).

Signed-off-by: Itay Donanhirsh <[email protected]>
Signed-off-by: Prakhar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants