repokitteh: pin modules to git SHAs. #9131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main goal here is to improve stability via hermetic description of RK dependencies. Signed-off-by: Harvey Tuch <[email protected]>
|
/rk-bless |
|
you are not allowed to bless this PR |
|
@itayd can you update my RK perms to support this? Thanks. |
|
/rk-bless |
|
@htuch are you going to update this? |
|
/assign test |
|
🙀 Error while processing event: |
Signed-off-by: Harvey Tuch <[email protected]>
|
/assign test |
|
test cannot be assigned to this issue. |
|
@itayd looks like it now works with the hash SHA syntax, thanks. |
itayd
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Looks good!
Just FYI you could also use https://www.repokitteh.io/docs/ref/funcs/#pin but pinning each module individually works too.
sthagen
added a commit
to sthagen/envoyproxy-envoy
that referenced
this pull request
Dec 4, 2019
repokitteh: pin modules to git SHAs. (envoyproxy#9131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here is to improve stability via hermetic description of RK dependencies.
Signed-off-by: Harvey Tuch [email protected]