Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring in repokitteh's ownercheck #7743

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Bring in repokitteh's ownercheck #7743

merged 1 commit into from
Jul 29, 2019

Conversation

itayd
Copy link
Contributor

@itayd itayd commented Jul 27, 2019 •
edited
Loading

Description:
Per #7423:

  • When a PR contains changes to api/, @envoyproxy/api-shepherds are notified via a CC comment.
  • When a PR contains changes to api/udpa, @envoyproxy/udpa-wg is notified via a CC comment.
  • An additional GitHub check blocking merge is added that will only be marked as passing once an approval review is received from someone in @envoyproxy/api-shepherds.

Risk Level:
None. But if there is any issue, please revert.

Testing:
In test PRs under different users: #7659

Docs Changes:
None.

Release Notes:
None

Fixes #7423

@itayd
Update repokitteh.star
3d8b1b1 
Signed-off-by: Itay Donanhirsh <[email protected]>
@itayd
Copy link
Contributor Author

itayd commented Jul 27, 2019

/review @htuch

@itayd
Copy link
Contributor Author

itayd commented Jul 27, 2019

/rk-bless

@repokitteh-read-only
Copy link

This PR has been blessed, meaning its repokitteh changes are in effect in this PR.

😽

Caused by: #7743 was labeled by repokitteh[bot].

see: more, trace.

htuch
htuch approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @envoyproxy/maintainers I'm going to merge this, please LMK if you notice any weird behavior around API related code reviews.

Thanks @itayd for the awesome work.

@htuch htuch merged commit 2d0b449 into envoyproxy:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htuch htuch htuch approved these changes

Assignees
No one assigned
Labels
rk:blessed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RepoKitteh-based selective CODEOWNERS enforcement on select subtrees
2 participants
@itayd @htuch